Bug 50337

Summary:

Web Inspector: Inspector protocol cleanup task

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

50401

Bug Blocks:

47775

Attachments:

Description	Flags
[patch] initial version.	none

Description Ilya Tikhonovsky 2010-12-01 11:15:50 PST

just small renames and adjustments for the protocol things.

'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned in the each backend to frontend messages.

At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.

Comment 1 Ilya Tikhonovsky 2010-12-01 14:01:25 PST

Created attachment 75320 [details]
[patch] initial version.

Comment 2 Pavel Feldman 2010-12-01 14:30:03 PST

Comment on attachment 75320 [details]
[patch] initial version.

View in context: https://bugs.webkit.org/attachment.cgi?id=75320&action=review

> LayoutTests/ChangeLog:5
> +        clean

Please provide a meaningful message.

> LayoutTests/inspector/report-API-errors-expected.txt:6
> +Protocol Error: the message is for not existing domain 'wrongDomain'

non-existing

> WebCore/inspector/front-end/inspector.js:523
> +    this.domains.Inspector = this;

I don't like "domains" object much. How about:

InspectorBackend.registerDomainDispatcher("Inspector", this);
InspectorBackend.registerDomainDispatcher("Resources", WebInspector.resourceManager);

Comment 3 Ilya Tikhonovsky 2010-12-03 15:41:56 PST

Committed r73315
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/WebDevToolsFrontendImpl.cpp
	M	WebCore/ChangeLog
	M	WebCore/inspector/CodeGeneratorInspector.pm
	M	WebCore/inspector/Inspector.idl
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/Callback.js
	M	LayoutTests/inspector/report-API-errors-expected.txt
	M	LayoutTests/inspector/report-API-errors.html
	M	LayoutTests/inspector/report-protocol-errors-expected.txt
	M	LayoutTests/inspector/report-protocol-errors.html
	M	LayoutTests/ChangeLog
r73315 = 452cc2aeaa47482b6ac77f9a7c77514e02642476 (refs/remotes/trunk)