Bug 50308 – Reject named colors, accept only #rrggbb in <input type=color />

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Dai Mikurube]

Due to HTML5 "4.10.7.1.15 Color state," <input type=color /> accepts only "simple colors" in the style of #xxxxxx.
> http://www.whatwg.org/specs/web-apps/current-work/multipage/number-state.html#color-state

[Dai Mikurube]

Created attachment 75247 [details]
Patch

[Kent Tamura]

Comment on attachment 75247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75247&action=review

> WebCore/html/ColorInputType.cpp:53
>      }
> -    // This accepts named colors such as "white".
> -    // FIXME: Reject named colors, accept only #rrggbb.
> -    Color color(value);
> -    return color.isValid() && !color.hasAlpha();
> +    return false;
>  }

We prefer early exit.  So this should be

if (value[0] != '#')
    return false;
// We don't accept #rgb .....

[Dai Mikurube]

Created attachment 75249 [details]
Patch

[Kent Tamura]

Comment on attachment 75249 [details]
Patch

ok

[WebKit Commit Bot]

Comment on attachment 75249 [details]
Patch

Clearing flags on attachment: 75249

Committed r73139: <http://trac.webkit.org/changeset/73139>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.