Summary: | Unable to indirectly animate visibility of SVGUseElement | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ken | ||||||||||
Component: | SVG | Assignee: | Rob Buis <rwlbuis> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, leo.yang, marek.raida, mdelaney7, rwlbuis, zimmermann | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac (Intel) | ||||||||||||
OS: | OS X 10.6 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 52630 | ||||||||||||
Attachments: |
|
Description
ken
2010-11-30 07:43:00 PST
Yes, I noticed the same buggy behavior in my game http://svg.kvalitne.cz/submarine/index.htm, which makes it unplayable at all.. :-( I'm enclosing similar testcase extracted from my game... Created attachment 75627 [details]
Broken behavior testcase, behaves the same bad way also on Windows platform...
Created attachment 78781 [details]
Patch
Comment on attachment 78781 [details]
Patch
Excellent catch! Code r+, Test r->
It's a pity that we need platform dependant results, maybe you could come up with a testcase that avoids font-size changes?
Can't you trigger the bug with parent fill='..' changes, or sth. else like stroke-width?
Created attachment 79120 [details]
Revised patch version 2
Using fill = "..." is a good idea. Maybe we don't need platform dependent test case because dumRenderTree can produce filling color in text.
Comment on attachment 79120 [details] Revised patch version 2 View in context: https://bugs.webkit.org/attachment.cgi?id=79120&action=review Excellent, almost r+. Our common style is to indidicate a "green rect" as success in the expected.png/txt files. Yours is red, please change the transition from black -> red, to red -> green, then I'll r+/cq+ it. Thanks for your patience :-) > LayoutTests/svg/custom/use-inherit-style.svg:8 > + <rect id="rect" x="0" y="0" width="100" height="60" /> Here you should use fill="red" as initial value... > LayoutTests/svg/custom/use-inherit-style.svg:17 > + document.getElementById("g").setAttribute("fill", "red"); ... and change it to fill="green" here. Created attachment 79235 [details]
Revised patch version 3
We can't set initial fill value for the rectangle because otherwise the rectangle will not inherit fill property of <g> element. Using "green" causes 0x008000 color value which isn't consistent with the existing truly green png, so 0x00FF00 is used explicitly.
(In reply to comment #7) > Created an attachment (id=79235) [details] > Revised patch version 3 > > We can't set initial fill value for the rectangle because otherwise the rectangle will not inherit fill property of <g> element. Using "green" causes 0x008000 color value which isn't consistent with the existing truly green png, so 0x00FF00 is used explicitly. I'm sorry, with 'truly green' I meant the "green" color value, 0x008000. Using "green" is perfectly fine. Comment on attachment 79235 [details]
Revised patch version 3
I don't care though whether the rect is 00FF00 or just 00FF00, either is fine, so r=me.
Comment on attachment 79235 [details] Revised patch version 3 Clearing flags on attachment: 79235 Committed r76027: <http://trac.webkit.org/changeset/76027> All reviewed patches have been landed. Closing bug. |