Bug 50238

Summary: WebKitTestRunner needs layoutTestController.findString
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mitz, sam
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation
none
Generate bindings for findString darin: review+

Adam Roben (:aroben)
Reported 2010-11-30 06:54:25 PST
r72887 added layoutTestController.findString. I'm going to add the one test that needs it to the mac-wk2 Skipped file. We should implement layoutTestController.findString so that we can run that test (and any future tests that are added that use it).
Attachments
Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation (18.79 KB, patch)
2010-11-30 11:06 PST, mitz 		no flags
DetailsFormatted DiffDiff
Generate bindings for findString (3.34 KB, patch)
2010-12-01 10:29 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-30 06:55:28 PST
<rdar://problem/8710645>
mitz
Comment 2 2010-11-30 11:06:03 PST
Created attachment 75169 [details] Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation
mitz
Comment 3 2010-11-30 11:13:03 PST
Comment on attachment 75169 [details] Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation Anders Carlsson reviewed this.
mitz
Comment 4 2010-11-30 11:18:16 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/72937>.
Adam Roben (:aroben)
Comment 5 2010-12-01 09:23:39 PST
It looks like findString still isn't exposed to JS: <http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r73025%20(5430)/editing/text-iterator/findString-pretty-diff.html> I think findString needs to be added to LayoutTestController.idl.
mitz
Comment 6 2010-12-01 09:54:27 PST
(In reply to comment #5) > It looks like findString still isn't exposed to JS: <http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r73025%20(5430)/editing/text-iterator/findString-pretty-diff.html> > > I think findString needs to be added to LayoutTestController.idl. I don’t see this failure when I do $ WebKitTestRunner LayoutTests/editing/text-iterator/findString.html Any idea why?
mitz
Comment 7 2010-12-01 10:29:34 PST
Created attachment 75288 [details] Generate bindings for findString
Eric Seidel (no email)
Comment 9 2010-12-14 01:29:25 PST
Comment on attachment 75169 [details] Add findString WebKit2 bundle API and WebKitTestRunner LayoutTestController findString implementation Cleared Dan Bernstein's review+ from obsolete attachment 75169 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Eric Seidel (no email)
Comment 10 2010-12-14 01:30:09 PST
Sounds like this is resolved?
Note You need to log in before you can comment on or make changes to this bug.