Bug 50236

Summary: [Qt] Implement layoutTestController.findString
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, mitz, mkosiba
Priority: P2 Keywords: LayoutTestFailure, PlatformOnly, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Adam Roben (:aroben)
Reported 2010-11-30 06:52:44 PST
r72887 added layoutTestController.findString and r72889 added the one test that uses it to the Skipped list. We should implement layoutTestController.findString so that we can run that test (and any future tests that are added that use it).
Attachments
Patch (5.50 KB, patch)
2010-11-30 09:35 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2010-11-30 09:35:50 PST
Created attachment 75158 [details] Patch Add the missing function. I don't cq? yet, the test does not pass, all find() call with AtWordStarts fail.
Benjamin Poulain
Comment 2 2010-11-30 10:11:47 PST
Ok, the test fails when Qt is compiled without ICU (default) because r72887 only implements the feature only for USE(ICU_UNICODE).
Antonio Gomes
Comment 3 2010-11-30 14:05:35 PST
Comment on attachment 75158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75158&action=review > WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:461 > + // 2. find the string I'd drop (1) and (2) comments here ... they are useless :)
WebKit Commit Bot
Comment 4 2010-11-30 20:19:01 PST
Comment on attachment 75158 [details] Patch Clearing flags on attachment: 75158 Committed r73007: <http://trac.webkit.org/changeset/73007>
WebKit Commit Bot
Comment 5 2010-11-30 20:19:06 PST
All reviewed patches have been landed. Closing bug.
Martin Kosiba
Comment 6 2011-11-17 10:54:20 PST
You forgot to uncomment the skipped findString layout test in platform/qt/Skipped:720.
Note You need to log in before you can comment on or make changes to this bug.