Bug 50208

Summary: [GTK] Build warnings in assertion code
Product: WebKit Reporter: Nicolas Dufresne <nicolas>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, eric, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
[GTK] Fix wrong type in assert return value none

Nicolas Dufresne
Reported 2010-11-29 22:16:45 PST
I just went across some code that returns wrong type in assertions (g_return_val_if_fail(...)). Will attach a patch soon.
Attachments
[GTK] Fix wrong type in assert return value (2.99 KB, patch)
2010-11-29 22:24 PST, Nicolas Dufresne 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nicolas Dufresne
Comment 1 2010-11-29 22:24:16 PST
Created attachment 75105 [details] [GTK] Fix wrong type in assert return value Use appropriate return type in different g_return_val_if_fail(). This removes some compiler warning.
WebKit Commit Bot
Comment 2 2010-11-30 09:04:05 PST
The commit-queue encountered the following flaky tests while processing attachment 75105 [details]: inspector/elements-panel-styles.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2010-11-30 09:26:55 PST
The commit-queue encountered the following flaky tests while processing attachment 75105 [details]: compositing/iframes/overlapped-nested-iframes.html compositing/iframes/iframe-size-from-zero.html Please file bugs against the tests. These tests were authored by ajwong@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-11-30 10:10:57 PST
The commit-queue encountered the following flaky tests while processing attachment 75105 [details]: fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T29.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by ap@webkit.org and dumi@chromium.org. The commit-queue is continuing to process your patch.
Eric Seidel (no email)
Comment 5 2010-11-30 11:35:22 PST
Bug 50255 tracks the flakey compositing test.
WebKit Commit Bot
Comment 6 2010-11-30 18:39:57 PST
The commit-queue encountered the following flaky tests while processing attachment 75105 [details]: compositing/iframes/overlapped-nested-iframes.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2010-11-30 20:00:03 PST
Comment on attachment 75105 [details] [GTK] Fix wrong type in assert return value Clearing flags on attachment: 75105 Committed r73006: <http://trac.webkit.org/changeset/73006>
WebKit Commit Bot
Comment 8 2010-11-30 20:00:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.