Summary: | WebKit2 authentication support | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | ap, buildbot, eric, webkit-ews | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||
OS: | All | ||||||||||||||||||||
Attachments: |
|
Description
Brady Eidson
2010-11-29 16:53:18 PST
Created attachment 75085 [details]
Skeleton files v1
Created attachment 75087 [details]
Skeleton files v2 (build works now)
Attachment 75085 [details] did not build on qt: Build output: http://queues.webkit.org/results/6343099 Attachment 75085 [details] did not build on mac: Build output: http://queues.webkit.org/results/6332089 Comment on attachment 75087 [details] Skeleton files v2 (build works now) View in context: https://bugs.webkit.org/attachment.cgi?id=75087&action=review Why is AuthenticationChallenge in the UIProcess and the others are in Shared. Can you explain how they will be used? > WebKit2/ChangeLog:7 > + Add new-file-skeletons to the projects as a first step before filling in the code. Weird spacing. > WebKit2/ChangeLog:49 > + * Shared/API/c/WKBase.h: > + > + * Shared/API/c/WKCredential.cpp: Added. > + (WKCredentialGetTypeID): > + * Shared/API/c/WKCredential.h: Added. > + * Shared/API/c/WKCredentialTypes.h: Added. > + > + * Shared/API/c/WKProtectionSpace.cpp: Added. > + (WKProtectionSpaceGetTypeID): > + * Shared/API/c/WKProtectionSpace.h: Added. > + * Shared/API/c/WKProtectionSpaceTypes.h: Added. > + > + * Shared/API/c/WKSharedAPICast.h: > + > + * Shared/APIObject.h: > + > + * Shared/WebCredential.cpp: Added. > + * Shared/WebCredential.h: Added. > + (WebKit::WebCredential::create): > + (WebKit::WebCredential::type): > + > + * Shared/WebProtectionSpace.cpp: Added. > + * Shared/WebProtectionSpace.h: Added. > + (WebKit::WebProtectionSpace::create): > + (WebKit::WebProtectionSpace::type): > + > + * UIProcess/API/C/WKAPICast.h: > + > + * UIProcess/API/C/WKAuthenticationChallenge.cpp: Added. > + (WKAuthenticationChallengeGetTypeID): > + * UIProcess/API/C/WKAuthenticationChallenge.h: Added. > + > + * UIProcess/WebAuthenticationChallenge.cpp: Added. > + * UIProcess/WebAuthenticationChallenge.h: Added. > + (WebKit::WebAuthenticationChallenge::create): > + (WebKit::WebAuthenticationChallenge::type): > + > + * WebKit2.pro: > + * WebKit2.xcodeproj/project.pbxproj: > + * win/WebKit2.vcproj: > + The paragraphing is weird here. How about some comments. > WebKit2/Shared/API/c/WKProtectionSpaceTypes.h:27 > +#ifndef WKCredentialTypes_h > +#define WKCredentialTypes_h This should be WKProtectionSpaceTypes_h > WebKit2/Shared/API/c/WKProtectionSpaceTypes.h:62 > +#endif /* WKCredentialTypes_h */ This one should also be WKProtectionSpaceTypes_h > WebKit2/UIProcess/WebAuthenticationChallenge.h:36 > +class WebAuthenticationChallenge : public APIObject > +{ > +public: The { is in the wrong place. Discussed this with Sam in person. Taking a different approach. Created attachment 75448 [details]
First stage v1
This patch gets all the API objects and clients in place, and does IPC to tell the UIProcess a challenge has occurred, and allows the UIProcess to respond.
After this infrastructure is in place, filling in the following holes will commence:
1 - Actually shipping Challenge, ProtectionSpace, and Credential data across the IPC boundary instead of empty representations of them.
2 - Provide the proper WK2 API for apps to actually be able to work with those 3 objects
Attachment 75448 [details] did not build on qt: Build output: http://queues.webkit.org/results/6746022 Attachment 75448 [details] did not build on win: Build output: http://queues.webkit.org/results/6825019 Created attachment 75500 [details]
First stage v2
Attempt at Windows and Qt build fixes
Attachment 75500 [details] did not build on qt: Build output: http://queues.webkit.org/results/6728028 Created attachment 75501 [details]
First stage v3 - More build fixes all around
Landed in r73281. More coming. Created attachment 75962 [details]
Stage 2 - Fill out necessary API and cross-process encoding
Attachment 75962 [details] did not build on win: Build output: http://queues.webkit.org/results/6789125 Created attachment 75993 [details]
Stage 2 v2 - Now with more Windows building!
Created attachment 75995 [details]
Stage 2 v3 - Now with more building all around
Forgot WebCore changes in the v2 patch
Comment on attachment 75995 [details]
Stage 2 v3 - Now with more building all around
r=me
Landed in r73614 |