Bug 50154

Summary: [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch proposal
none
Patch proposal mrobinson: review+

Description Mario Sanchez Prada 2010-11-29 07:12:30 PST
Currently, we're getting the following stderr output when running LayoutTests/accessibility/non-data-table-cell-title-ui-element.html:

    atk_object_get_attributes: assertion `ATK_IS_OBJECT (accessible)' failed

...which is caused because of the following function in DRT is not properly checking m_element, as it's done in the rest of the functions.
Comment 1 Mario Sanchez Prada 2010-11-29 08:27:00 PST
Created attachment 75028 [details]
Patch proposal

Attached -yet another really simple- patch to fix this issue, found while working on bug 50062 (unrelated, though)
Comment 2 Mario Sanchez Prada 2010-11-29 08:43:01 PST
Created attachment 75034 [details]
Patch proposal

Sorry, need to sleep better the night before when I'm planning to multitask as I'm doing today...

Now attaching the right patch
Comment 3 Martin Robinson 2010-11-29 08:45:56 PST
Comment on attachment 75034 [details]
Patch proposal

Looks good. No test needed for this, as it should fix an issue observed during tests.
Comment 4 Mario Sanchez Prada 2010-11-29 09:24:24 PST
Committed r72804: <http://trac.webkit.org/changeset/72804>
Comment 5 WebKit Review Bot 2010-11-29 10:35:53 PST
http://trac.webkit.org/changeset/72804 might have broken Leopard Intel Release (Tests)