| Summary: | [chromium] pass webframe to web frame client's cookieJar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||
| Component: | New Bugs | Assignee: | jochen | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fishd | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
jochen
2010-11-29 04:16:50 PST
Created attachment 75014 [details]
Patch
Comment on attachment 75014 [details]
Patch
To avoid breaking Chromium builds with this commit, I think you should
land a Chromium change first that has RenderView::cookieJar(WebFrame*)
implemented. That way, when this patch lands, everything will continue
working.
landed chromium side Comment on attachment 75014 [details] Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderStyle.o /Projects/CommitQueue/WebCore/rendering/style/RenderStyle.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderSVGContainer.o /Projects/CommitQueue/WebCore/rendering/RenderSVGContainer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (358 failures) Full output: http://queues.webkit.org/results/6400105 Comment on attachment 75014 [details]
Patch
Compile failed, but maybe try again?
Comment on attachment 75014 [details] Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: e/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGPolygonElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGPolygonElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGStyleElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGStyleElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (305 failures) Full output: http://queues.webkit.org/results/6354102 Comment on attachment 75014 [details]
Patch
trying commit queue once more after rolling chromium deps
Comment on attachment 75014 [details] Patch Clearing flags on attachment: 75014 Committed r72901: <http://trac.webkit.org/changeset/72901> All reviewed patches have been landed. Closing bug. |