Bug 50131

Summary: Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, webkit-ews
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch v1
none
patch v1.1 - right file none

Antonio Gomes
Reported 2010-11-28 07:32:13 PST
We decided to use the static method in SpatialNavigation.h throughout WebCore instead of directly checking Settings.h. Reason: in a soon future, I will also incorporate a isCaretBrowsing check into this method (and probably rename it accordingly) to avoid feature conflicts (spatial navigation x caret browsing). Patch coming ...
Attachments
patch v1 (2.89 KB, patch)
2010-11-28 07:37 PST, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
patch v1.1 - right file (3.00 KB, patch)
2010-11-28 07:44 PST, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-11-28 07:37:44 PST
Created attachment 74973 [details] patch v1
Antonio Gomes
Comment 2 2010-11-28 07:42:33 PST
Comment on attachment 74973 [details] patch v1 err .. Broken patch
Antonio Gomes
Comment 3 2010-11-28 07:44:45 PST
Created attachment 74974 [details] patch v1.1 - right file
Early Warning System Bot
Comment 4 2010-11-28 07:48:00 PST
Attachment 74973 [details] did not build on qt: Build output: http://queues.webkit.org/results/6407076
Eric Seidel (no email)
Comment 5 2010-11-28 07:50:39 PST
Attachment 74973 [details] did not build on mac: Build output: http://queues.webkit.org/results/6409064
Eric Seidel (no email)
Comment 6 2010-11-28 08:00:00 PST
Attachment 74973 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6293085
WebKit Commit Bot
Comment 7 2010-11-28 10:51:48 PST
Comment on attachment 74974 [details] patch v1.1 - right file Clearing flags on attachment: 74974 Committed r72780: <http://trac.webkit.org/changeset/72780>
WebKit Commit Bot
Comment 8 2010-11-28 10:51:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.