Bug 50088

Summary:

Web Inspector: highlight diffs of revisions against base version.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

38578

Attachments:

Description	Flags
[PATCH] Proposed change.	yurys: review+

Pavel Feldman

Reported 2010-11-25 09:12:47 PST

Patch to follow.

Attachments
[PATCH] Proposed change. (11.90 KB, patch) 2010-11-25 09:27 PST, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-11-25 09:27:15 PST

Created attachment 74887 [details] [PATCH] Proposed change.

Yury Semikhatsky

Comment 2 2010-11-25 09:56:06 PST

Comment on attachment 74887 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=74887&action=review > WebCore/inspector/front-end/ResourcesPanel.js:372 > + if (resource.__initialRevision && resource.content && view instanceof WebInspector.SourceView) { Please rename __initialRevision to _baseRevision > WebCore/inspector/front-end/ResourcesPanel.js:1109 > + this._resource.__initialRevision = revisionResource; This field should be encapsulated into the resource. Please file a bug on this and do it in a separate CL.

Pavel Feldman

Comment 3 2010-11-25 10:02:09 PST

M WebCore/ChangeLog M WebCore/inspector/front-end/CSSStyleModel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/SourceView.js M WebCore/inspector/front-end/textViewer.css M WebCore/inspector/front-end/utilities.js Committed r72737

Note You need to log in before you can comment on or make changes to this bug.