Bug 50079

Summary:

[Qt] Remove empty ScrollView::platformInit/platformDestroy

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Renata Hodovan <rhodovan.u-szeged>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Andreas Kling

Reported 2010-11-25 07:15:14 PST

The implementations of ScrollView::platformInit() and ScrollView::platformDestroy() in ScrollViewQt.cpp are empty. We should remove them and just use the empty ones in ScrollView.cpp.

Attachments
Patch (1.62 KB, text/plain) 2010-11-26 07:31 PST, Renata Hodovan	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Renata Hodovan

Comment 1 2010-11-26 07:31:06 PST

Created attachment 74939 [details] Patch

Renata Hodovan

Comment 2 2010-11-26 07:38:10 PST

This is landed in <http://trac.webkit.org/changeset/72761> Closing bug.

Balazs Kelemen

Comment 3 2010-11-26 08:04:19 PST

Comment on attachment 74939 [details] Patch Clearing flags

WebKit Review Bot

Comment 4 2010-11-26 08:19:55 PST

http://trac.webkit.org/changeset/72761 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html

Note You need to log in before you can comment on or make changes to this bug.