Bug 50076

Summary:

Web Inspector: LayoutTest/inspector/extnesions.html is flaky

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	pfeldman: review-
patch	pfeldman: review+, pfeldman: commit-queue-

Andrey Kosyakov

Reported 2010-11-25 06:54:39 PST

extension_testExtensionWatchSidebarExpression() sometimes dumps an empty sidebar pane, here's how it happens: 1. The test requests result of expression evaluated on inspected page to be rendered in sidebar pane 2. ExtensionWatchSidebarPane evaluates expression in page 3. When expression is evaluated, ExtensionWatchSidebarPane creates ObjectPropertiesSection, adds the result object and expands it the secion 4. ExtensionWatchSidebarPane dispatches a notification to client (test extension) on sidebar being updated. 5. ObjectPropertiesSection retrieves list of remote object properties in the inspected page (4) happens asynchronously WRT (5), so test extension may dump an empty sidebar before remote properties list arrives.

Attachments
patch (1.48 KB, patch) 2010-11-25 07:04 PST, Andrey Kosyakov	pfeldman: review-	Details Formatted Diff Diff
patch (1.53 KB, patch) 2010-11-25 07:18 PST, Andrey Kosyakov	pfeldman: review+ pfeldman: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2010-11-25 07:04:36 PST

Created attachment 74874 [details] patch

Pavel Feldman

Comment 2 2010-11-25 07:06:48 PST

Comment on attachment 74874 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=74874&action=review > LayoutTests/inspector/extensions.html:63 > + webInspector.inspectedWindow.eval("", bind(extension_dumpSidebarContent, null, nextTest)); Please use runAfterPendingDispatches.

Andrey Kosyakov

Comment 3 2010-11-25 07:18:55 PST

Created attachment 74875 [details] patch

Andrey Kosyakov

Comment 4 2010-11-26 05:03:50 PST

Manually committed r72755: http://trac.webkit.org/changeset/72755

Note You need to log in before you can comment on or make changes to this bug.