Bug 50074

Summary: Remove WebCore/platform/mac/GeolocationServiceMac.{h,mm}
Product: WebKit Reporter: John Knottenbelt <jknotten>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, eric, sam, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 40373    
Attachments:
Description Flags
Patch none

John Knottenbelt
Reported 2010-11-25 06:34:15 PST
GeolocationService is deprecated in favour of the client-based design. Since WebKit mac uses client-based design, this code is not used and can be removed.
Attachments
Patch (11.18 KB, patch)
2010-12-09 07:51 PST, John Knottenbelt 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Knottenbelt
Comment 1 2010-12-09 07:51:56 PST
Created attachment 76065 [details] Patch
Steve Block
Comment 2 2010-12-10 06:46:51 PST
The client-based Mac implementation was added by Sam in http://trac.webkit.org/changeset/52368. Mac already builds with the client-based impl so this is dead code.
Steve Block
Comment 3 2010-12-10 06:48:45 PST
Comment on attachment 76065 [details] Patch LGTM, but let's give Sam a chance to reply before you submit.
Eric Seidel (no email)
Comment 4 2010-12-10 20:59:55 PST
Comment on attachment 76065 [details] Patch LGTM. We can easily resurrect this from svn if needed. If it doesn't break any builds, it's unlikely to be used.
Eric Seidel (no email)
Comment 5 2010-12-10 21:00:10 PST
CCing someone from iOS too.
WebKit Commit Bot
Comment 6 2010-12-10 22:50:23 PST
Comment on attachment 76065 [details] Patch Clearing flags on attachment: 76065 Committed r73839: <http://trac.webkit.org/changeset/73839>
WebKit Commit Bot
Comment 7 2010-12-10 22:50:29 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 8 2010-12-11 10:12:56 PST
(In reply to comment #5) > CCing someone from iOS too. Thanks Eric. The iOS port is using non-client-based Geolocation, but our implementation is in a file called GeolocationServiceCoreLocation.mm which hasn't been upstreamed yet. The GeolocationServiceMac.* source files were not used by the iOS port.
Note You need to log in before you can comment on or make changes to this bug.