Summary: | Calculate the -webkit-pixel-radio using the device DPI. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
Component: | WebKit Qt | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, gustavo, gyuyoung.kim, kling | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2010-11-25 02:01:53 PST
Created attachment 74845 [details]
Patch
Comment on attachment 74845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74845&action=review Did you intend to set the patch to r? first? > WebKit/qt/Api/qwebpage.cpp:2510 > + d->pixelRatio = conf.devicePixelRatio; This makes the const function in QWebPage have a side-effect. Wouldn't it be cleaner to change the pixelRatio right before emitting the viewportAttributesChanged() signal? The commit-queue encountered the following flaky tests while processing attachment 74845 [details]: inspector/syntax-highlight-css.html java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. These tests were authored by ap@webkit.org, keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org. The commit-queue is continuing to process your patch. (In reply to comment #2) > (From update of attachment 74845 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74845&action=review > > Did you intend to set the patch to r? first? > > > WebKit/qt/Api/qwebpage.cpp:2510 > > + d->pixelRatio = conf.devicePixelRatio; > > This makes the const function in QWebPage have a side-effect. Wouldn't it be cleaner to change the pixelRatio right before emitting the viewportAttributesChanged() signal? That won't work unfortunately. We only know the pixel ratio after computing the viewport. The commit-queue encountered the following flaky tests while processing attachment 74845 [details]: inspector/console-log-before-inspector-open.html compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by caseq@chromium.org, eric@webkit.org, simon.fraser@apple.com, and yurys@chromium.org. The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 74845 [details]: http/tests/appcache/foreign-fallback.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 74845 [details] Patch Rejecting patch 74845 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 74845]" exit_code: 1 Last 500 characters of output: dit Fetching: https://bugs.webkit.org/show_bug.cgi?id=50059&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 74845 from bug 50059. Andreas Kling and Simon Hausmann found in /Projects/CommitQueue/WebKit/qt/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/WebKit/qt/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/6390045 Committed r72726: <http://trac.webkit.org/changeset/72726> |