Summary: | Need to initialize destination variables before calling GL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gregg Tavares <gman> | ||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kbr | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Gregg Tavares
2010-11-24 18:14:33 PST
I have a patch to fix the places in WebKit where this is an issue. It would be great if you could submit your patch. Run prepare-ChangeLog, edit the modified ChangeLogs appropriately, and webkit-patch upload to upload it. See http://webkit.org/coding/contributing.html . Created attachment 75075 [details]
Patch
Comment on attachment 75075 [details]
Patch
The code changes look fine, and sorry for the nitpick, but could you please change your editor's settings to not modify existing whitespace, and regenerate the patch? I've been advised by other WebKit reviewers that whitespace changes should not be done in conjunction with code changes. It would be great if you would file a separate bug and submit a patch just for the whitespace cleanups.
Created attachment 75447 [details]
Patch
Comment on attachment 75447 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75447&action=review > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:846 > + m_maxTextureSize = 0; I'm surprised this isn't initialized in the constructor. Comment on attachment 75447 [details] Patch Clearing flags on attachment: 75447 Committed r73244: <http://trac.webkit.org/changeset/73244> All reviewed patches have been landed. Closing bug. |