Summary: | WK2 Context Menu Items need a user data object and a client callback for selection | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, sullivan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2010-11-24 14:53:58 PST
Created attachment 74801 [details]
Patch v1
Comment on attachment 74801 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=74801&action=review > WebKit2/UIProcess/WebPageContextMenuClient.h:42 > + void customContextMenuItemSelected(WebPageProxy* page, const WebContextMenuItemData&); Can omit “page” here. > WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:92 > + item.setUserData([static_cast<WebUserDataWrapper*>(representedObject) userData]); Needs a space before the *. > WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:144 > + WebUserDataWrapper* wrapper = [[WebUserDataWrapper alloc] initWithUserData:items[i].userData()]; Ditto. Also missing a call to [super init] in the implementation of [WebUserDataWrapper initWithUserData:]. Whoops, sorry about that John, had already prepped and typed the magic command when your feedback came through. I followed up with r72709 http://trac.webkit.org/changeset/72707 might have broken GTK Linux 32-bit Release The following tests are not passing: inspector/extensions.html |