Bug 49970

Summary: Fix minor errors in IndexedDB
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, hans, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch steveblock: review+

Description Jeremy Orlow 2010-11-23 06:11:17 PST
Fix minor errors in IndexedDB
Comment 1 Jeremy Orlow 2010-11-23 06:22:29 PST
Created attachment 74656 [details]
Patch
Comment 2 Jeremy Orlow 2010-11-23 06:23:05 PST
Here's an easy one.
Comment 3 Hans Wennborg 2010-11-23 06:28:28 PST
(In reply to comment #1)
> Created an attachment (id=74656) [details]
> Patch

Looks good. I like the test.
Comment 4 Andrei Popescu 2010-11-23 06:53:24 PST
> function testCreateAndRemove()
> function openSuccess()

I think these two functions should be defined in the opposite order in the layout test file. Other than that, LGTM.
Comment 5 Steve Block 2010-11-24 09:14:56 PST
Comment on attachment 74656 [details]
Patch

I agree with Andrei's comment about re-ordering.
Comment 6 Jeremy Orlow 2010-11-24 09:57:50 PST
Committed r72682: <http://trac.webkit.org/changeset/72682>