Bug 49960 – Web Inspector: [STYLES] invalid color values are not marked as such.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Edit any color: in style and set its value to "red foo bar":

color: red foo bar

Expected: color value is committed, bogus value is not used when rendering, there is a warning icon next to property
Actual: color value is committed, bogus value is not used when rendering, but there is no warning icon is there

[Alexander Pavlov (apavlov)]

Created attachment 74638 [details]
[PATCH] Suggested fix

[Pavel Feldman]

Comment on attachment 74638 [details]
[PATCH] Suggested fix

As you noted offline, overrides will make invalid property look parsedOk.

[Alexander Pavlov (apavlov)]

Created attachment 74676 [details]
[PATCH] Corrected solution

[Pavel Feldman]

Comment on attachment 74676 [details]
[PATCH] Corrected solution

View in context: https://bugs.webkit.org/attachment.cgi?id=74676&action=review

> WebCore/inspector/InspectorStyleSheet.cpp:448
> +                bool shouldInactivate = false;

Please add following comment here:
Parsed property overrides any property with the same name. Non-parsed property overrides previous non-parsed property with the same name.

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/resources/styles-new-API.css
        M       LayoutTests/inspector/styles-new-API-expected.txt
        M       LayoutTests/inspector/styles-source-offsets-expected.txt
        M       WebCore/ChangeLog
        M       WebCore/css/CSSGrammar.y
        M       WebCore/inspector/InspectorStyleSheet.cpp
Committed r72615