Summary: | Web Inspector: [STYLES] invalid color values are not marked as such. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-11-22 22:34:07 PST
Created attachment 74638 [details]
[PATCH] Suggested fix
Comment on attachment 74638 [details]
[PATCH] Suggested fix
As you noted offline, overrides will make invalid property look parsedOk.
Created attachment 74676 [details]
[PATCH] Corrected solution
Comment on attachment 74676 [details] [PATCH] Corrected solution View in context: https://bugs.webkit.org/attachment.cgi?id=74676&action=review > WebCore/inspector/InspectorStyleSheet.cpp:448 > + bool shouldInactivate = false; Please add following comment here: Parsed property overrides any property with the same name. Non-parsed property overrides previous non-parsed property with the same name. Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/resources/styles-new-API.css M LayoutTests/inspector/styles-new-API-expected.txt M LayoutTests/inspector/styles-source-offsets-expected.txt M WebCore/ChangeLog M WebCore/css/CSSGrammar.y M WebCore/inspector/InspectorStyleSheet.cpp Committed r72615 |