Summary: | [NRWT] Opening png sometimes fails on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dpranke, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Hayato Ito
2010-11-22 10:34:49 PST
Created attachment 74572 [details]
retry-opening
Comment on attachment 74572 [details] retry-opening View in context: https://bugs.webkit.org/attachment.cgi?id=74572&action=review > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:464 > + except IOError: Can we catch the exact IO error using errno? > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:466 > + time.sleep(timeout_seconds / retry_num) > + continue I would probably try more frequently than every 500ms, maybe increase retry_num to 50? Created attachment 74578 [details]
retry-opening-increase-retry_num-use-errno
Thank you for the review. I addressed your comments. (In reply to comment #2) > (From update of attachment 74572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74572&action=review > > > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:464 > > + except IOError: > > Can we catch the exact IO error using errno? Nice point. Done. > > > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:466 > > + time.sleep(timeout_seconds / retry_num) > > + continue > > I would probably try more frequently than every 500ms, maybe increase retry_num to 50? Done. Comment on attachment 74578 [details]
retry-opening-increase-retry_num-use-errno
Thanks!
change LGTM as well. Comment on attachment 74578 [details] retry-opening-increase-retry_num-use-errno Clearing flags on attachment: 74578 Committed r72547: <http://trac.webkit.org/changeset/72547> All reviewed patches have been landed. Closing bug. |