Summary: | Web Inspector: add timing tab to the network item view. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2010-11-22 09:42:36 PST
Created attachment 74564 [details]
[IMAGE] Looks with the patch applied.
Created attachment 74565 [details]
[PATCH] Proposed change.
Comment on attachment 74565 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=74565&action=review > WebCore/inspector/front-end/NetworkItemView.js:50 > + this._tabbedPane.appendTab("timing", WebInspector.UIString("Timing"), this._timingView); Shouldn't this be conditional on browser supporting resource timing? Always showing a tab with no useful information seems unfortunate. > WebCore/inspector/front-end/ResourceTimingView.js:50 > + this._emptyMsgElement = document.createElement("div"); > + this._emptyMsgElement.className = "storage-empty-view"; > + this._emptyMsgElement.textContent = WebInspector.UIString("This request has no detailed timing info."); > + this.element.appendChild(this._emptyMsgElement); > + } Again, I'd rather replace with with createChild one-liner. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/inspector/front-end/NetworkItemView.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/Resource.js A WebCore/inspector/front-end/ResourceTimingView.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.html M WebCore/inspector/front-end/networkPanel.css M WebKit/chromium/src/js/DevTools.js Committed r72657 |