Bug 49918

Summary:

[Qt] StillImage::draw() shouldn't call setCompositionMode() unless the QPaintEngine has Porter-Duff composition

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Renata Hodovan <rhodovan.u-szeged>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none

Description Andreas Kling 2010-11-22 09:30:09 PST

To avoid QPainter moaning on the console.

Basically, we need to check if (painter->paintEngine()->hasFeature(QPaintEngine::PorterDuff)). Note that this isn't relevant when painting on a QImage.

Comment 1 Andreas Kling 2010-12-15 09:49:07 PST

Created attachment 76657 [details]
Proposed patch

Comment 2 Ariya Hidayat 2010-12-15 15:26:02 PST

Comment on attachment 76657 [details]
Proposed patch

LGTM.

Comment 3 WebKit Commit Bot 2010-12-15 17:08:26 PST

The commit-queue encountered the following flaky tests while processing attachment 76657 [details]:

fast/canvas/webgl/tex-sub-image-2d.html bug 51153 (authors: abarth@webkit.org, kbr@google.com, and zmo@google.com)
accessibility/media-element.html bug 51154 (author: eric.carlson@apple.com)
The commit-queue is continuing to process your patch.

Comment 4 WebKit Commit Bot 2010-12-15 17:15:59 PST

Comment on attachment 76657 [details]
Proposed patch

Clearing flags on attachment: 76657

Committed r74165: <http://trac.webkit.org/changeset/74165>

Comment 5 WebKit Commit Bot 2010-12-15 17:16:05 PST

All reviewed patches have been landed.  Closing bug.