Bug 49916

Summary: [Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Renata Hodovan <rhodovan.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2010-11-22 09:24:27 PST
The GraphicsContextPlatformPrivate destructor currently calls QPainter::end() before deleting the paint device. QPainter::device() will always return 0 after calling end(), so this code is leaking the device.
Attachments
Patch (1.28 KB, patch)
2010-11-29 04:43 PST, Renata Hodovan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Renata Hodovan
Comment 1 2010-11-29 04:43:02 PST
Created attachment 75016 [details] Patch
Renata Hodovan
Comment 2 2010-11-30 05:41:40 PST
This is landed in <http://trac.webkit.org/changeset/72907>.
Balazs Kelemen
Comment 3 2010-11-30 07:58:23 PST
Comment on attachment 75016 [details] Patch Clearing flags. Please do not forget it next time! ;)
Renata Hodovan
Comment 4 2010-11-30 08:03:22 PST
(In reply to comment #3) > (From update of attachment 75016 [details]) > Clearing flags. Please do not forget > it next time! ;) Thank you very much ;)
Note You need to log in before you can comment on or make changes to this bug.