Bug 49877 – [GTK] DumpRenderTree has two copies of JavaScriptCore

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

One copy of JavaScriptCore is included in libwebkit.so. The other copy is compiled directly into DumpRenderTree. The original reason for this appears to be that when compiling libwebkit.so we hide JavaScriptCore symbols that DumpRenderTree needs.

[Martin Robinson]

Created attachment 74495 [details]
Make JSC symbols visible. Remove second JSC from DRT.

[WebKit Review Bot]

Attachment 74495 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6236087

[Xan Lopez]

Comment on attachment 74495 [details]
Make JSC symbols visible. Remove second JSC from DRT.

Great catch. Don't commit it yet until we can make a clean build in gustavo's bot I guess...

[Antonio Gomes]

Oh ... I am wondering why I could just crash on release builds, while it works fine on debug.

[Martin Robinson]

(In reply to comment #4)
> Oh ... I am wondering why I could just crash on release builds, while it works fine on debug.

Debug builds use the system allocator, so CString was just using malloc/free instead of fastMalloc/fastFree. 

After some fiddling, I was able to get Debug building using TCMalloc, but I ran into a bunch of other crashes. I wouldn't be surprised if they were related to this as well.

[Antonio Gomes]

this is what I got when I built patch in bug 	48429  and the one here:

WebKitTools/DumpRenderTree/Programs_DumpRenderTree-LayoutTestController.o: In function `WTF::FastAllocBase::operator new(unsigned int)':
LayoutTestController.cpp:(.text._ZN3WTF13FastAllocBasenwEj[WTF::FastAllocBase::operator new(unsigned int)]+0xd): undefined reference to `WTF::fastMalloc(unsigned int)'
WebKitTools/DumpRenderTree/cairo/Programs_DumpRenderTree-PixelDumpSupportCairo.o: In function `computeMD5HashStringForBitmapContext(BitmapContext*, char*)':
/home/agomes/Devel/webkit/webkit/WebKitBuild/Gtk/Debug/../../../WebKitTools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:78: undefined reference to `WTF::MD5::addBytes(unsigned char const*, unsigned int)'
/home/agomes/Devel/webkit/webkit/WebKitBuild/Gtk/Debug/../../../WebKitTools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:82: undefined reference to `WTF::MD5::checksum(WTF::Vector<unsigned char, 16u>&)'
WebKitTools/DumpRenderTree/cairo/Programs_DumpRenderTree-PixelDumpSupportCairo.o: In function `WTF::VectorBufferBase<unsigned char>::allocateBuffer(unsigned int)':
/home/agomes/Devel/webkit/webkit/WebKitBuild/Gtk/Debug/../../../JavaScriptCore/wtf/Vector.h:287: undefined reference to `WTF::fastMalloc(unsigned int)'
WebKitTools/DumpRenderTree/gtk/Programs_DumpRenderTree-AccessibilityUIElementGtk.o: In function `WTF::VectorBufferBase<AccessibilityUIElement>::allocateBuffer(unsigned int)':
AccessibilityUIElementGtk.cpp:(.text._ZN3WTF16VectorBufferBaseI22AccessibilityUIElementE14allocateBufferEj[WTF::VectorBufferBase<AccessibilityUIElement>::allocateBuffer(unsigned int)]+0x3d): undefined reference to `WTF::fastMalloc(unsigned int)'
collect2: ld returned 1 exit status
make[1]: *** [Programs/DumpRenderTree] Error 1
make[1]: Leaving directory `/home/agomes/Devel/webkit/webkit/WebKitBuild/Gtk/Debug'
make: *** [all] Error 2
rm DerivedSources/WebCore/JSSVGExternalResourcesRequired.cpp DerivedSources/WebCore/JSSVGFilterPrimitiveStandardAttributes.cpp DerivedSources/WebCore/JSSVGTests.cpp DerivedSources/WebCore/JSSVGViewSpec.cpp DerivedSources/WebCore/JSSVGTransformable.cpp DerivedSources/WebCore/JSSVGZoomAndPan.cpp DerivedSources/WebCore/JSSVGFitToViewBox.cpp DerivedSources/WebCore/JSSVGURIReference.cpp DerivedSources/WebCore/JSSVGLocatable.cpp DerivedSources/WebCore/JSSVGStylable.cpp DerivedSources/WebCore/JSElementTimeControl.cpp DerivedSources/WebCore/JSSVGLangSpace.cpp

[Martin Robinson]

(In reply to comment #6)
> this is what I got when I built patch in bug     48429  and the one here:
> 
> WebKitTools/DumpRenderTree/Programs_DumpRenderTree-LayoutTestController.o: In function `WTF::FastAllocBase::operator new(unsigned int)':
> LayoutTestController.cpp:

This patch will require a full rebuild:

rm -rf WebKitBuild/Release
build-webkit --gtk

If you did a full rebuild and it still breaks, something is definitely wrong. :/

[Antonio Gomes]

(In reply to comment #7)
> (In reply to comment #6)
> > this is what I got when I built patch in bug     48429  and the one here:
> > 
> > WebKitTools/DumpRenderTree/Programs_DumpRenderTree-LayoutTestController.o: In function `WTF::FastAllocBase::operator new(unsigned int)':
> > LayoutTestController.cpp:
> 
> This patch will require a full rebuild:
> 
> rm -rf WebKitBuild/Release
> build-webkit --gtk
> 
> If you did a full rebuild and it still breaks, something is definitely wrong. :/

It was a full build, martin.

[Martin Robinson]

(In reply to comment #8)

> It was a full build, martin.

I just tried both full debug and release builds here and they seemed to work. :/ Do you mind pasting the output of this command on your system?

$ nm -o WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc

[Antonio Gomes]

<lisppaste> tonikitoo pasted "build error for mrobinson" at http://paste.lisp.org/display/116904
<tonikitoo> after a clean release build with the patch
<tonikitoo> r72495

after pasting I realized you were not there :)

[Antonio Gomes]

:/ Do you mind pasting the output of this command on your system?
> 
> $ nm -o WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc

$  nm -o WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c4636 t _ZN3WTF10fastMallocEj
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c4978 T _ZN3WTF14fastMallocSizeEPKv
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c445a t _ZN3WTF15fastMallocAllowEv
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c4443 t _ZN3WTF16fastMallocForbidEv
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c4957 T _ZN3WTF20fastMallocStatisticsEv
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:003447be t _ZN3WTF27fastMallocMatchValidateFreeEPvNS_8Internal9AllocTypeE
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:003447b9 t _ZN3WTF29fastMallocMatchValidateMallocEPvNS_8Internal9AllocTypeE
WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:0216b4fd r _ZZN3WTF10fastMallocEjE19__PRETTY_FUNCTION__

[Martin Robinson]

(In reply to comment #11)
> :/ Do you mind pasting the output of this command on your system?
> > 
> > $ nm -o WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc
> 
> $  nm -o WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc
> WebKitBuild/Gtk/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:011c4636 t _ZN3WTF10fastMallocEj

I wonder if the issue is that the mangling is different for me:

martin@chazmcpoodle:~/WebKit-old$  nm -o WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0.3.1 | grep fastMalloc
WebKitBuild/Debug/.libs/libwebkitgtk-1.0.so.0.3.1:00000000018fe90e T _ZN3WTF10fastMallocEm
...

Might be worth a shot to try adding the mangled names for the missing symbols to webkit/symbols.filter on your side. Can't imagine what else is wrong.

[Antonio Gomes]

(In reply to comment #10)
> <lisppaste> tonikitoo pasted "build error for mrobinson" at http://paste.lisp.org/display/116904
> <tonikitoo> after a clean release build with the patch
> <tonikitoo> r72495
> 
> after pasting I realized you were not there :)

Ignore this build error. I am getting them on trunk, clean build, with any patch on top... =/

[Antonio Gomes]

Guys, progresses here?

[Martin Robinson]

(In reply to comment #14)
> Guys, progresses here?

We're still waiting to hear from Gustavo about arranging a clean build on the release bots.

[Martin Robinson]

Committed r73150: <http://trac.webkit.org/changeset/73150>

[Martin Robinson]

*** Bug 36088 has been marked as a duplicate of this bug. ***