Bug 49812 – [NRWT] Simplify Driver.run_test() so that it takes only one parameter, TestInput.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Hayato Ito]

Currently, each driver's run_test() method receives filename, timeout and checksum as parameters.
It might be better that run_test() only receives one parameter, TestInput.

[Hayato Ito]

Created attachment 74403 [details]
simplify-run-test

[Hayato Ito]

In this refactoring, I assume:

self._port.uri_to_test_name(self._port.filname_to_uri(filename)) == self._port.relative_test_filename(filename)

It seems this relation is always true. If my assumption is wrong, plese let me know.

[Dirk Pranke]

Comment on attachment 74403 [details]
simplify-run-test

View in context: https://bugs.webkit.org/attachment.cgi?id=74403&action=review

Patch looks good to me . There are a couple of minor nits below.

> WebKitTools/Scripts/webkitpy/layout_tests/driver_test.py:45
>      image_path = 'image_result.png'

Please just delete this file; even I don't really have a use for it any more. Originally I intended it to be a way for people to test their port Driver implementations w/o needing the rest of the NRWT scaffolding, but I don't think it's that useful at this point.

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:106
> +        # checksums match. The image_hash is set lazily to reduce startup time.

Please change the second sentence to something like "The image hash is set later, and only if it is needed for the test". I want to remove the "lazy" part of this.

[Shinichiro Hamaji]

Comment on attachment 74403 [details]
simplify-run-test

r+ assuming you'll address Dirk's comments

[Hayato Ito]

Thank you for the review, Dirk.
I'll address your comments and will land the updated patch later. Thank you.

(In reply to comment #3)
> (From update of attachment 74403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74403&action=review
> 
> Patch looks good to me . There are a couple of minor nits below.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/driver_test.py:45
> >      image_path = 'image_result.png'
> 
> Please just delete this file; even I don't really have a use for it any more. Originally I intended it to be a way for people to test their port Driver implementations w/o needing the rest of the NRWT scaffolding, but I don't think it's that useful at this point.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:106
> > +        # checksums match. The image_hash is set lazily to reduce startup time.
> 
> Please change the second sentence to something like "The image hash is set later, and only if it is needed for the test". I want to remove the "lazy" part of this.

[Hayato Ito]

Committed r72551: <http://trac.webkit.org/changeset/72551>