Bug 49807

Summary: Don't call invalidateSVGAttributes() from the setFooBaseValue() methods
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch krit: review+

Nikolas Zimmermann
Reported 2010-11-19 08:14:26 PST
set##UpperProperty##BaseValue() used to call invalidateSVGAttributes(), because it was used to propagate SVG DOM changes to the elements. This is no longer true, and we can avoid calling this method. Now, when doing: rectElement.setAttribute("x", "150"); rectElement.getAttribute("x"); we would reconstruct the 'x' attribute from the SVG DOM baseVal, which is not necessary in any way.
Attachments
Patch (8.17 KB, patch)
2010-11-19 08:20 PST, Nikolas Zimmermann
krit: review+
Nikolas Zimmermann
Comment 1 2010-11-19 08:20:33 PST
Dirk Schulze
Comment 2 2010-11-19 08:26:27 PST
Comment on attachment 74392 [details] Patch r=mw
Nikolas Zimmermann
Comment 3 2010-11-19 08:29:34 PST
Landed in r72405.
Note You need to log in before you can comment on or make changes to this bug.