Summary: | [chromium] Add a mechanism for creating a WebURLLoader that is associated with a particular WebFrame | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> | ||||||
Component: | WebKit API | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ajwong, michaeln, scherkus | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Darin Fisher (:fishd, Google)
2010-11-18 15:15:50 PST
Created attachment 74300 [details]
v1 patch
Comment on attachment 74300 [details] v1 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74300&action=review This looks ok to me. > WebKit/chromium/public/WebFrame.h:335 > + // will, for example, be cancelled when WebFrame::stopLoading is called. Until this is implemented in terms of SubresourceLoader, they'll run beyond stopLoading (i think). If that right maybe add a FIXME here to clarify the current behavior. > WebKit/chromium/src/AssociatedURLLoader.h:50 > + virtual void loadSynchronously(const WebURLRequest&, WebURLResponse&, WebURLError&, WebData& data); No need for 'data' param name. Created attachment 74322 [details]
v2 patch
Thanks for the feedback Michael!
Comment on attachment 74322 [details] v2 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74322&action=review nit-nit > WebKit/chromium/src/AssociatedURLLoader.cpp:79 > +void AssociatedURLLoader::PrepareRequest(WebURLRequest& request) prepareRequest? :) Landed as http://trac.webkit.org/changeset/72616 |