Bug 49748

Summary: [Qt] Compile with QT_NO_SCRIPT
Product: WebKit Reporter: Sam Magnuson <smagnuso>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, hausmann, kent.hansen, laszlo.gombos, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch laszlo.gombos: review-

Sam Magnuson
Reported 2010-11-18 10:42:36 PST
I don't need QtScript so I'm compiling without it. QtWebKit, however, depends upon QtScript for an enum in the addJavaScriptObjectToWindow. I submitted: http://qt.gitorious.org/qt/qt/merge_requests/930 to Qt to move the enum into QtCore so that QtScript isn't necesary. This is the WebKit side using the new enum.
Attachments
Patch (10.36 KB, patch)
2010-11-18 10:44 PST, Sam Magnuson 		laszlo.gombos: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Magnuson
Comment 1 2010-11-18 10:44:28 PST
Created attachment 74257 [details] Patch
Early Warning System Bot
Comment 2 2010-11-18 11:03:12 PST
Attachment 74257 [details] did not build on qt: Build output: http://queues.webkit.org/results/6247027
Laszlo Gombos
Comment 3 2010-11-19 08:54:03 PST
Comment on attachment 74257 [details] Patch I do not think we can accept changes (with no proper build guards) that are relying on an unapproved/unreleased version of Qt API. We might be able to revisit this after the underlying Qt API is released. In addition we have plans to unify the QtScript engine with the engine used by QtWebKit. Once these plans realize maintaining the QT_NO_SCRIPT configuration for QtWebKit will no longer make sense. Can you perhaps maintain these changes on your private branch instead of upstreaming them to the trunk ? r- as with our current processing, this commit would break the build.
Benjamin Poulain
Comment 4 2011-01-28 19:32:31 PST
*** This bug has been marked as a duplicate of bug 52469 ***
Note You need to log in before you can comment on or make changes to this bug.