Bug 49729

Summary:

Web Inspector: reduce the footprint of InspectorBackendDispatcher.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, buildbot, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

49732

Bug Blocks:

Attachments:

Description	Flags
[patch] initial version.	none
sample InspectorBackendDispatcher.cpp	none

Ilya Tikhonovsky

Reported 2010-11-18 06:46:12 PST

%subj%

Attachments
[patch] initial version. (6.58 KB, patch) 2010-11-18 06:53 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
sample InspectorBackendDispatcher.cpp (152.94 KB, text/x-c++src) 2010-11-18 06:56 PST, Ilya Tikhonovsky	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2010-11-18 06:53:58 PST

Created attachment 74234 [details] [patch] initial version.

Ilya Tikhonovsky

Comment 2 2010-11-18 06:56:35 PST

Created attachment 74235 [details] sample InspectorBackendDispatcher.cpp

Yury Semikhatsky

Comment 3 2010-11-18 06:59:47 PST

Comment on attachment 74234 [details] [patch] initial version. View in context: https://bugs.webkit.org/attachment.cgi?id=74234&action=review > WebCore/ChangeLog:6 > + InspectorBackendDispatcher is a generated file. Please provide a meaningful change log entry describing the change details. > WebCore/inspector/CodeGeneratorInspector.pm:354 > + $typeString =~ s/\b(\w)/\U$1/g; Please comment these two lines.

Build Bot

Comment 4 2010-11-18 07:07:24 PST

Attachment 74234 [details] did not build on win: Build output: http://queues.webkit.org/results/6250016

Pavel Feldman

Comment 5 2010-11-19 03:21:40 PST

Rolled out for breaking core builders. Please remember to close bugs upon landing patches.

WebKit Review Bot

Comment 6 2010-11-19 03:33:23 PST

http://trac.webkit.org/changeset/72373 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/report-protocol-errors.html

Ilya Tikhonovsky

Comment 7 2010-11-19 07:35:27 PST

Comment on attachment 74234 [details] [patch] initial version. Committed r72398 M WebCore/ChangeLog M WebCore/inspector/CodeGeneratorInspector.pm r72398 = 2585c11bab6a48b308ad24608a88d24dd88c210e (refs/remotes/trunk)

Ilya Tikhonovsky

Comment 8 2010-11-19 07:35:49 PST

landed. Closing the bug.

Note You need to log in before you can comment on or make changes to this bug.