Bug 49716

Summary: Add more validation message functions
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch 2 none

Kent Tamura
Reported 2010-11-17 23:26:56 PST
As discussed in http://codereview.chromium.org/4678006/, Chromium has a plain to reuse Firefox's messages. Firefox has some type-specific valueMissing messages.
Attachments
Patch (23.82 KB, patch)
2010-11-17 23:32 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (24.23 KB, patch)
2010-11-18 15:25 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-11-17 23:32:36 PST
Created attachment 74208 [details] Patch
Tony Chang
Comment 2 2010-11-18 10:11:47 PST
Comment on attachment 74208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74208&action=review > WebCore/html/ValidityState.cpp:46 > - if (valueMissing()) > - return validationMessageValueMissingText(); > if (patternMismatch()) > return validationMessagePatternMismatchText(); Do we need to check valueMissing before pattermMismatch?
Kent Tamura
Comment 3 2010-11-18 15:06:25 PST
Comment on attachment 74208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74208&action=review >> WebCore/html/ValidityState.cpp:46 >> return validationMessagePatternMismatchText(); > > Do we need to check valueMissing before pattermMismatch? Oh, good point. If a page has <input required pattern="[0-9]{4}"> and the field is empty, we should show valueMissing message, not patternMismatch message.
Kent Tamura
Comment 4 2010-11-18 15:25:14 PST
Created attachment 74302 [details] Patch 2
Kent Tamura
Comment 5 2010-11-18 20:48:57 PST
Comment on attachment 74302 [details] Patch 2 Clearing flags on attachment: 74302 Committed r72363: <http://trac.webkit.org/changeset/72363>
Kent Tamura
Comment 6 2010-11-18 20:49:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.