Bug 49697

Summary: Move length and slice out of ArrayBufferView interface
Product: WebKit Reporter: Jian Li <jianli>
Component: WebGLAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch kbr: review+, jianli: commit-queue-

Jian Li
Reported 2010-11-17 16:27:22 PST
Since we're going to add DataView, we need to move length and slice out of ArrayBufferView interface.
Attachments
Proposed Patch (33.90 KB, patch)
2010-11-17 17:15 PST, Jian Li 		kbr: review+
jianli: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2010-11-17 17:15:58 PST
Created attachment 74182 [details] Proposed Patch
Kenneth Russell
Comment 2 2010-11-18 13:30:41 PST
Comment on attachment 74182 [details] Proposed Patch This looks good. Thanks for picking it up. I'm assuming you ran the layout tests under fast/canvas/webgl (which include the Typed Array unit tests) on both Safari and Chromium.
Jian Li
Comment 3 2010-11-18 16:13:25 PST
Committed as http://trac.webkit.org/changeset/72343.
Note You need to log in before you can comment on or make changes to this bug.