Bug 49643

Summary: Changes to LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mrowe, wsiegrist
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Make changes to the Mac WebKit2 Skipped file trigger Windows builds sfalken: review+

Adam Roben (:aroben)
Reported 2010-11-16 22:35:41 PST
r72167 modified LayoutTests/platform/mac-wk2/Skipped, but it did not trigger a Windows build. Windows uses this file (and the test results in that directory) when running tests using WebKit2, so changes to it should trigger a Windows build.
Attachments
Make changes to the Mac WebKit2 Skipped file trigger Windows builds (2.52 KB, patch)
2010-11-17 10:11 PST, Adam Roben (:aroben) 		sfalken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-17 10:11:25 PST
Created attachment 74130 [details] Make changes to the Mac WebKit2 Skipped file trigger Windows builds
Adam Roben (:aroben)
Comment 2 2010-11-17 10:14:26 PST
Committed r72218: <http://trac.webkit.org/changeset/72218>
Adam Roben (:aroben)
Comment 3 2010-11-17 10:15:02 PST
Bill, this change requires a master restart to take effect. It's not super critical to do it quickly, though.
Eric Seidel (no email)
Comment 4 2010-11-17 10:16:48 PST
We could have the windows bot make this decision instead of the master to avoid the restart.
Adam Roben (:aroben)
Comment 5 2010-11-17 10:21:39 PST
(In reply to comment #4) > We could have the windows bot make this decision instead of the master to avoid the restart. That's an interesting idea. It might confuse our tools to have a build that doesn't produce anything but isn't a failure, however.
William Siegrist
Comment 6 2010-11-17 10:32:10 PST
Master restarted.
Note You need to log in before you can comment on or make changes to this bug.