| Summary: | [Qt] Focus ring does not show for image maps | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, tonikitoo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 36044 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yael
2010-11-16 12:56:20 PST
Created attachment 74039 [details]
Patch
Comment on attachment 74039 [details]
Patch
r=me.
It seems that a fair amount of code could potentially be shared between the two GraphicsContext::drawFocusRing functions (and perhaps get rid if the "if 0" guard in the already landed code).
Yael, after landing this, can you open a new bug for sharing the code ?
Comment on attachment 74039 [details]
Patch
Thanks for the review, Laszlo,
I'll do the cleanup next.
why no tests? :( (In reply to comment #2) > (From update of attachment 74039 [details]) > r=me. > > It seems that a fair amount of code could potentially be shared between the two GraphicsContext::drawFocusRing functions (and perhaps get rid if the "if 0" guard in the already landed code). > > Yael, after landing this, can you open a new bug for sharing the code ? Unfortunately, we cannot enable the "#if 0" for drawing the focus ring around links. It gives very bad results. e.g. when a link spans multiple lines, the path between those lines is garbled. (In reply to comment #4) > why no tests? :( I am about to enable the test LayoutTests/fast/images/imagemap-focus-ring.html for this. Comment on attachment 74039 [details]
Patch
It *must* land together or should be in the changelog.
Created attachment 74154 [details]
Patch
Same patch as before, with updated test result.
Comment on attachment 74039 [details] Patch Cleared Laszlo Gombos's review+ from obsolete attachment 74039 [details] so that this bug does not appear in http://webkit.org/pending-commit. The commit-queue encountered the following flaky tests while processing attachment 74154 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html http/tests/loading/deleted-host-in-resource-load-delegate-callback.html Please file bugs against the tests. These tests were authored by beidson@apple.com and dumi@chromium.org. The commit-queue is continuing to process your patch. Comment on attachment 74154 [details] Patch Clearing flags on attachment: 74154 Committed r72371: <http://trac.webkit.org/changeset/72371> All reviewed patches have been landed. Closing bug. |