Bug 49615 – [Qt] Focus ring does not show for image maps

• Component: Accessibility
• Status: RESOLVED FIXED

[Yael]

http://trac.webkit.org/changeset/53857 added support for focus rings on imagemaps, but each port needs to implement
GraphicsContext::drawFocusRing(const Vector<Path>& paths, int width, int offset, const Color& color) in order to see a focus ring.

[Yael]

Created attachment 74039 [details]
Patch

[Laszlo Gombos]

Comment on attachment 74039 [details]
Patch

r=me.

It seems that a fair amount of code could potentially be shared between the two GraphicsContext::drawFocusRing functions (and perhaps get rid if the "if 0" guard in the already landed code).

Yael, after landing this, can you open a new bug for sharing the code ?

[Yael]

Comment on attachment 74039 [details]
Patch

Thanks for the review, Laszlo,
I'll do the cleanup next.

[Antonio Gomes]

why no tests? :(

[Yael]

(In reply to comment #2)
> (From update of attachment 74039 [details])
> r=me.
> 
> It seems that a fair amount of code could potentially be shared between the two GraphicsContext::drawFocusRing functions (and perhaps get rid if the "if 0" guard in the already landed code).
> 
> Yael, after landing this, can you open a new bug for sharing the code ?

Unfortunately, we cannot enable the "#if 0" for drawing the focus ring around links. It gives very bad results. e.g. when a link spans multiple lines, the path between those lines is garbled.

[Yael]

(In reply to comment #4)
> why no tests? :(

I am about to enable the test LayoutTests/fast/images/imagemap-focus-ring.html for this.

[Antonio Gomes]

Comment on attachment 74039 [details]
Patch

It *must* land together or should be in the changelog.

[Yael]

Created attachment 74154 [details]
Patch

Same patch as before, with updated test result.

[Eric Seidel (no email)]

Comment on attachment 74039 [details]
Patch

Cleared Laszlo Gombos's review+ from obsolete attachment 74039 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74154 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html
http/tests/loading/deleted-host-in-resource-load-delegate-callback.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74154 [details]
Patch

Clearing flags on attachment: 74154

Committed r72371: <http://trac.webkit.org/changeset/72371>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.