Bug 49607
| Summary: | [Chromium] Need unit tests for WebInputEventFactory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Stuart Morgan <stuartmorgan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | chandra.vallala, schenney |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Stuart Morgan
The OS event conversions that happen in WebInputEventFactory don't appear to have any unit tests, and the event tests in general (from what I could find) generate internal event structures and run tests based on those. There doesn't seem to be any testing of the actual OS event conversion, which isn't ideal.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
chandra shekar vallala
(In reply to comment #0)
> The OS event conversions that happen in WebInputEventFactory don't appear to have any unit tests, and the event tests in general (from what I could find) generate internal event structures and run tests based on those. There doesn't seem to be any testing of the actual OS event conversion, which isn't ideal.
"testing of the actual OS event conversion" means should we check for all WebInputEvent values ?
Stuart Morgan
Meaning we should start with a native OS event with known properties, run it through the conversion, and ensure that the resulting WebInputEvent has those properties.
(As an example, I filed this bug after finding and fixing a bug in the click count never being set when converting a Mac mouse event.)
Stephen Chenney
https://code.google.com/p/chromium/issues/detail?id=230533