|Summary:||jsc does not ignore shebang|
|Product:||WebKit||Reporter:||John Tantalo <john.tantalo>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.6|
Description John Tantalo 2010-11-15 20:42:12 PST
Comment 1 John Tantalo 2010-11-15 20:55:41 PST
Comment 2 John Tantalo 2010-11-15 21:49:31 PST
Created attachment 73960 [details] proposed patch Replaced diff with a real patch, with a test, changelog, and correct style.
Comment 3 Geoffrey Garen 2010-11-16 10:58:58 PST
Comment on attachment 73960 [details] proposed patch I think you've made this change at the wrong level of abstraction. Accounting for shebang in the lexer applies this Unix-only rule to all web pages and operating systems. I think a better fix would be for the jsc tool itself to strip out shebang before evaluating a source file.
Comment 4 John Tantalo 2010-11-16 11:18:27 PST
Comment 5 Geoffrey Garen 2010-11-29 11:40:03 PST
Comment on attachment 74017 [details] proposed patch r=me
Comment 6 WebKit Commit Bot 2010-12-06 10:47:50 PST
Comment on attachment 74017 [details] proposed patch Clearing flags on attachment: 74017 Committed r73377: <http://trac.webkit.org/changeset/73377>
Comment 7 WebKit Commit Bot 2010-12-06 10:47:56 PST
All reviewed patches have been landed. Closing bug.