Bug 49545 – [Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView

• Component: WebKit2
• Status: RESOLVED FIXED

[Benjamin Poulain]

Created attachment 73902 [details]
Inputs for testing

It seems tabbing between fields does not work with QGraphicsWKView.

To reproduce, open Minibrowser on the attached file and enjoy :)

[Benjamin Poulain]

Created attachment 74006 [details]
Patch

The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome.

[Kenneth Rohde Christiansen]

Comment on attachment 74006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74006&action=review

> WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:146
> +class FriendlyWidget : public QWidget

Simon says that this is OK :-)

[WebKit Commit Bot]

Comment on attachment 74006 [details]
Patch

Rejecting patch 74006 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74006]" exit_code: 2
Last 500 characters of output:
ceeded at 81 (offset 6 lines).
patching file WebKit2/UIProcess/API/qt/qwkpage.cpp
patching file WebKit2/UIProcess/API/qt/qwkpage.h
Hunk #1 FAILED at 112.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/API/qt/qwkpage.h.rej
patching file WebKit2/UIProcess/API/qt/qwkpage_p.h
Hunk #1 succeeded at 55 with fuzz 1 (offset 1 line).

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6182013

[Benjamin Poulain]

Committed r72202: <http://trac.webkit.org/changeset/72202>

[Balazs Kelemen]

(In reply to comment #1)
> Created an attachment (id=74006) [details]
> Patch
> 
> The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome.

What is the purpose of that? We are assuming the concrete type of the QWidget, 
right? Why not qobject_cast? Or am I misinterpreting it?

[Benjamin Poulain]

(In reply to comment #5)
> > The FriendlyWidget of QGraphicsWKView::focusNextPrevChildCallback() is one hell of a ugly hack. Any idea to do that better is welcome.
> 
> What is the purpose of that? We are assuming the concrete type of the QWidget, 
> right? Why not qobject_cast? Or am I misinterpreting it?

It is to change the visibility of a method. This method is usually available through QWidget, but here we are in a QGraphicsWidget, so we can't access it directly.

This cast is a way to make a protected method public.