[Qt] Path fill lacks blur shadow support

• Component: Canvas
• Status: RESOLVED FIXED

[Helder Correia]

fillPath() will draw only solid shadows, even with shadowBlur set.

[Helder Correia]

Created attachment 73812 [details]
Patch

[Andreas Kling]

Comment on attachment 73812 [details]
Patch

What about filling with a gradient or pattern with alpha? Seems like it won't be covered by this change.

[Helder Correia]

Created attachment 74445 [details]
Patch

[Helder Correia]

Created attachment 74449 [details]
Test for stroke gradient and fill, not path

[Helder Correia]

Comment on attachment 74449 [details]
Test for stroke gradient and fill, not path

Added this patch to the wrong bug.

[Andreas Kling]

Comment on attachment 74445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74445&action=review

Looks good, except one thing:

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:550
> +            QPainter* shadowPainter = shadow->beginShadowLayer(p, path.boundingRect());

QPainterPath::boundingRect() is slow, you should use the controlPointRect() trick here since you only need an approximation.

[Helder Correia]

Created attachment 74468 [details]
Use the faster controlPointRect()

[Andreas Kling]

Comment on attachment 74468 [details]
Use the faster controlPointRect()

r=me

[WebKit Commit Bot]

Comment on attachment 74468 [details]
Use the faster controlPointRect()

Clearing flags on attachment: 74468

Committed r72472: <http://trac.webkit.org/changeset/72472>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.