Bug 49491

Summary: [Qt] Path fill lacks blur shadow support
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, mdelaney7
Priority: P2 Keywords: HTML5, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 34479    
Attachments:
Description Flags
Patch
none
Patch
none
Test for stroke gradient and fill, not path
none
Use the faster controlPointRect() none

Helder Correia
Reported 2010-11-13 01:09:29 PST
fillPath() will draw only solid shadows, even with shadowBlur set.
Attachments
Patch (7.98 KB, patch)
2010-11-13 01:11 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (8.04 KB, patch)
2010-11-19 16:57 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Test for stroke gradient and fill, not path (8.47 KB, patch)
2010-11-19 17:31 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Use the faster controlPointRect() (8.04 KB, patch)
2010-11-19 22:36 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-11-13 01:11:54 PST
Created attachment 73812 [details] Patch
Andreas Kling
Comment 2 2010-11-15 02:19:41 PST
Comment on attachment 73812 [details] Patch What about filling with a gradient or pattern with alpha? Seems like it won't be covered by this change.
Helder Correia
Comment 3 2010-11-19 16:57:46 PST
Created attachment 74445 [details] Patch
Helder Correia
Comment 4 2010-11-19 17:31:58 PST
Created attachment 74449 [details] Test for stroke gradient and fill, not path
Helder Correia
Comment 5 2010-11-19 17:32:50 PST
Comment on attachment 74449 [details] Test for stroke gradient and fill, not path Added this patch to the wrong bug.
Andreas Kling
Comment 6 2010-11-19 20:54:49 PST
Comment on attachment 74445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74445&action=review Looks good, except one thing: > WebCore/platform/graphics/qt/GraphicsContextQt.cpp:550 > + QPainter* shadowPainter = shadow->beginShadowLayer(p, path.boundingRect()); QPainterPath::boundingRect() is slow, you should use the controlPointRect() trick here since you only need an approximation.
Helder Correia
Comment 7 2010-11-19 22:36:21 PST
Created attachment 74468 [details] Use the faster controlPointRect()
Andreas Kling
Comment 8 2010-11-19 22:38:52 PST
Comment on attachment 74468 [details] Use the faster controlPointRect() r=me
WebKit Commit Bot
Comment 9 2010-11-20 02:10:08 PST
Comment on attachment 74468 [details] Use the faster controlPointRect() Clearing flags on attachment: 74468 Committed r72472: <http://trac.webkit.org/changeset/72472>
WebKit Commit Bot
Comment 10 2010-11-20 02:10:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.