Bug 49466

Summary: REGRESSION(r71895): API test javaScriptWindowObjectCleared fails
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, hausmann, kling, ossy, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch tonikitoo: review+, kling: commit-queue-

Ryosuke Niwa
Reported 2010-11-12 12:19:12 PST
After http://trac.webkit.org/changeset/71895, javaScriptWindowObjectCleared fails. Test content: 2396 void tst_QWebFrame::javaScriptWindowObjectCleared() 2397 { 2398 QWebPage page; 2399 QWebFrame* frame = page.mainFrame(); 2400 QSignalSpy spy(frame, SIGNAL(javaScriptWindowObjectCleared())); 2401 QFETCH(QString, html); 2402 frame->setHtml(html); 2403 2404 QFETCH(int, signalCount); 2405 QCOMPARE(spy.count(), signalCount); 2406 } http://doc.qt.nokia.com/4.7/qwebframe.html#javaScriptWindowObjectCleared "This signal is emitted whenever the global window object of the JavaScript environment is cleared, e.g., before starting a new load." We emit this signal when FrameLoader::dispatchDidClearWindowObjectInWorld() is called. The failing test checks that loading the following HTML causes one emission of that signal: "<html><body><script></script><p>hello world</p></body></html>" On Mac, dispatchDidClearWindowObjectInWorld is called when loading: <html><body><script></script><p>hello world</p></body></html> #0 0x101865b54 in WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds at FrameLoader.cpp:3348 #1 0x101869ac6 in WebCore::FrameLoader::receivedFirstData at FrameLoader.cpp:617 #2 0x101869cee in WebCore::FrameLoader::willSetEncoding at FrameLoader.cpp:1089 #3 0x101710989 in WebCore::DocumentWriter::setEncoding at DocumentWriter.cpp:236 #4 0x1017016d0 in WebCore::DocumentLoader::commitData at DocumentLoader.cpp:306 #5 0x100f34f76 in -[WebFrame(WebInternal) _commitData:] at WebFrame.mm:957 #6 0x100f5d8d6 in -[WebHTMLRepresentation receivedData:withDataSource:] at WebHTMLRepresentation.mm:173 #7 0x100f1d8c8 in -[WebDataSource(WebInternal) _receivedData:] at WebDataSource.mm:239 #8 0x100f407eb in WebFrameLoaderClient::committedLoad at WebFrameLoaderClient.mm:856 #9 0x101701825 in WebCore::DocumentLoader::commitLoad at DocumentLoader.cpp:293 #10 0x10170187e in WebCore::DocumentLoader::receivedData at DocumentLoader.cpp:320 #11 0x101d61d2e in WebCore::MainResourceLoader::addData at MainResourceLoader.cpp:157 #12 0x101f762c4 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:276 #13 0x101d6147f in WebCore::MainResourceLoader::didReceiveData at MainResourceLoader.cpp:436 #14 0x101f75ab6 in WebCore::ResourceLoader::didReceiveData at ResourceLoader.cpp:429
Attachments
Proposed patch (1.37 KB, patch)
2010-11-14 09:58 PST, Andreas Kling 		tonikitoo: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-11-12 12:22:47 PST
The failing test was added by http://trac.webkit.org/changeset/48166.
Andreas Kling
Comment 2 2010-11-14 09:58:42 PST
Created attachment 73849 [details] Proposed patch
Antonio Gomes
Comment 3 2010-11-14 10:20:54 PST
Comment on attachment 73849 [details] Proposed patch Maybe adding a comment, kl0ng?
Andreas Kling
Comment 4 2010-11-14 10:23:00 PST
Comment on attachment 73849 [details] Proposed patch > Maybe adding a comment, kl0ng? Sure thing, mang!
Andreas Kling
Comment 5 2010-11-14 10:43:50 PST
Committed r71983: <http://trac.webkit.org/changeset/71983>
Note You need to log in before you can comment on or make changes to this bug.