Bug 49384

Summary:

LayoutTest fast/dom/DeviceOrientation/event-after-navigation.html is flaky

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hans, jorlow, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	jorlow: review+

Steve Block

Reported 2010-11-11 07:37:25 PST

This is an asynchronous script test which navigates the main page but relies on js-test-post.js calling LayoutTestController.waitUntilDone(). It's possible for the main page to be navigated and hence the load of js-test-post.js to be cancelled before LayoutTestController.waitUntilDone() is called, which causes the test to fail.

Attachments
patch (1.60 KB, patch) 2010-11-11 07:44 PST, Steve Block	no flags	Details Formatted Diff Diff
patch (1.60 KB, patch) 2010-11-11 07:45 PST, Steve Block	jorlow: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2010-11-11 07:44:17 PST

Created attachment 73610 [details] patch

Steve Block

Comment 2 2010-11-11 07:45:24 PST

Created attachment 73611 [details] patch

Jeremy Orlow

Comment 3 2010-11-23 04:02:27 PST

Comment on attachment 73611 [details] patch The comment you put in the bug should also be in the change log. r=me

Steve Block

Comment 4 2010-11-24 03:43:00 PST

Committed r72658: <http://trac.webkit.org/changeset/72658>

Ryosuke Niwa

Comment 5 2011-02-06 22:16:56 PST

Comment on attachment 73611 [details] patch Clearing cq flag so that this patch won't appear on the review queue.

Note You need to log in before you can comment on or make changes to this bug.