Bug 49360

Summary: new-run-webkit-tests: respect set-webkit-configuration again
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bulach, eric, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 49361    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dirk Pranke
Reported 2010-11-10 19:30:46 PST
the refactoring out of the Config object had a typo that caused NRWT to stop respecting set-webkit-configuration again :(
Attachments
Patch (3.23 KB, patch)
2010-11-10 19:32 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2010-11-11 14:32 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (10.52 KB, patch)
2010-11-12 17:51 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-11-10 19:32:03 PST
Created attachment 73571 [details] Patch
Dirk Pranke
Comment 2 2010-11-11 14:32:41 PST
Created attachment 73665 [details] Patch
Adam Roben (:aroben)
Comment 3 2010-11-11 14:38:13 PST
Comment on attachment 73665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73665&action=review > WebKitTools/Scripts/webkitpy/layout_tests/port/config_standalone.py:56 > + else: > + e = executive.Executive() > + fs = filesystem.FileSystem() Is this really needed? It's never used.
Dirk Pranke
Comment 4 2010-11-11 14:39:09 PST
(In reply to comment #3) > (From update of attachment 73665 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73665&action=review > > > WebKitTools/Scripts/webkitpy/layout_tests/port/config_standalone.py:56 > > + else: > > + e = executive.Executive() > > + fs = filesystem.FileSystem() > > Is this really needed? It's never used. Yeah, I've used it by hand to verify that the actual codepath works, and I'll probably use it in the future when we have "integration tests".
Eric Seidel (no email)
Comment 5 2010-11-11 15:21:12 PST
Comment on attachment 73665 [details] Patch Sigh. We really need to kill that static. Thanks for fixing.
Dirk Pranke
Comment 6 2010-11-11 15:51:11 PST
Comment on attachment 73665 [details] Patch Clearing flags on attachment: 73665 Committed r71858: <http://trac.webkit.org/changeset/71858>
Dirk Pranke
Comment 7 2010-11-11 15:51:15 PST
All reviewed patches have been landed. Closing bug.
Mihai Parparita
Comment 8 2010-11-12 08:31:16 PST
This broke the NaCl tests, which use new-run-webkit-httpd, which also tries to get the configuration (unclear if it needs it): http://build.chromium.org/p/chromium/builders/NACL%20Tests/builds/1636/steps/nacl_ui_tests/logs/stdio The breakage is preventing WebKit rolls, so I'm going to roll this out for now.
Mihai Parparita
Comment 9 2010-11-12 08:38:25 PST
(In reply to comment #8) > The breakage is preventing WebKit rolls, so I'm going to roll this out for now. Rolled out with http://trac.webkit.org/changeset/71916.
Dirk Pranke
Comment 10 2010-11-12 17:51:30 PST
Created attachment 73801 [details] Patch
Dirk Pranke
Comment 11 2010-11-12 18:01:03 PST
Comment on attachment 73801 [details] Patch Clearing flags on attachment: 73801 Committed r71960: <http://trac.webkit.org/changeset/71960>
Dirk Pranke
Comment 12 2010-11-12 18:01:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.