Summary: | Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, krit, mdelaney7, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 47905 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-11-10 02:15:42 PST
Created attachment 73492 [details]
Patch
Attachment 73492 [details] did not build on mac: Build output: http://queues.webkit.org/results/5506085 Attachment 73492 [details] did not build on mac: Build output: http://queues.webkit.org/results/5438080 Created attachment 73522 [details]
Patch v2
Not sure why mac build failed, probably an unused variable. If it fails again, I'll try a release build.
This patch is significantly larger, as it contains several new testcases.
Attachment 73522 [details] did not build on mac: Build output: http://queues.webkit.org/results/5613002 Attachment 73522 [details] did not build on mac: Build output: http://queues.webkit.org/results/5501087 (In reply to comment #6) > Attachment 73522 [details] did not build on mac: > Build output: http://queues.webkit.org/results/5501087 The error is real, I tried a build from scratch, and it turns out I forgot to add SVGAnimatedTransformList.h to Xcode, no works fine. Not sure if it's worth uploading a new version just for that though Comment on attachment 73522 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=73522&action=review We already talked about some issues on IRC, just add some notes to bugzilla review as well. I may forgot to note some change wishes here :-) Niko already fixed Mac. Great Patch Niko! Looking forward to see the same work on SVGPathSegList :-D r=me > WebCore/svg/SVGTransformList.cpp:66 > + return String::format("matrix(%f %f %f %f %f %f)", matrix.a(), matrix.b(), matrix.c(), matrix.d(), matrix.e(), matrix.f()); Don't use String::format here ;-) We talked about this on IRC right now. > WebCore/svg/SVGTransformable.cpp:192 > + list.append(t); Can you rename t to transform please? And please fix the indentation as well on switch .. case later in the code. Fixed all issues, landing. Committed r71802: <http://trac.webkit.org/changeset/71802> |