Summary: | FileSystem: Fix a link error for non-chromium WebKit build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kavita Kanetkar <kkanetkar> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dumi, ericu, kinuko | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Kavita Kanetkar
2010-11-09 19:06:58 PST
Created attachment 73452 [details]
patch
Comment on attachment 73452 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=73452&action=review > WebCore/inspector/InspectorFileSystemAgent.cpp:123 > + // FIXME: Remove guard when file system is supported for non-chromium platforms. This comment does not look really accurate; must be like 'when revealFolderInOS is implemented on non-chromium platforms'. > WebCore/inspector/InspectorFileSystemAgent.cpp:124 > WebCore::revealFolderInOS(path); I don't think you need WebCore:: here. (Aren't we in WebCore namespace?) Created attachment 73506 [details]
patch
The WebCore:: is for resolving scope, since InspectorFileSystemAgent's method name is the same.
Comment on attachment 73506 [details]
patch
lgtm!
Comment on attachment 73506 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=73506&action=review Looks good except the minor issue. Please fix it before you land the patch. > WebCore/inspector/InspectorFileSystemAgent.cpp:127 > +void InspectorFileSystemAgent::revealFolderInOS(const String&) { } Please add "notImplemented();". Created attachment 73668 [details]
patch
I am not a committer so it needs to go through cq. Please take a look.
Thanks.
Comment on attachment 73668 [details]
patch
rs=me, based on jian's and kinuko's reviews.
Comment on attachment 73506 [details] patch Cleared Jian Li's review+ from obsolete attachment 73506 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 73668 [details] patch Clearing flags on attachment: 73668 Committed r71885: <http://trac.webkit.org/changeset/71885> All reviewed patches have been landed. Closing bug. |