Summary: | [Chromium/DRT] Make EventSendingController send complete touch events. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Kroeger <rjkroege> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Robert Kroeger
2010-11-09 15:37:19 PST
Created attachment 73505 [details]
p1 for 49285
Comment on attachment 73505 [details] p1 for 49285 View in context: https://bugs.webkit.org/attachment.cgi?id=73505&action=review Patch looks good, but please fix/remove the comment before landing. > WebKitTools/DumpRenderTree/chromium/EventSender.cpp:878 > + // Force a layout here just to make sure every position has been > + // determined before we send events (as well as all the other methods > + // that send an event do). This comment doesn't seem very helpful, I'd just leave it out. It's also not entirely accurate from what I can tell (it won't change the position argument passed on this event). Created attachment 73527 [details]
Addressed review comments.
Comment on attachment 73505 [details] p1 for 49285 Cleared James Robinson's review+ from obsolete attachment 73505 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 73527 [details]
Addressed review comments.
Cool!
Comment on attachment 73527 [details] Addressed review comments. Rejecting patch 73527 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/5744004 Comment on attachment 73527 [details] Addressed review comments. Clearing flags on attachment: 73527 Committed r71921: <http://trac.webkit.org/changeset/71921> All reviewed patches have been landed. Closing bug. |