Bug 49272

Summary: HTML5 Ruby support should be mandatory feature
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, buildbot, hyatt, rolandsteiner
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 48755    
Bug Blocks:    
Attachments:
Description Flags
proposed patch
none
proposed patch v2
none
proposed patch v3
none
proposed patch v4
none
proposed patch v5 none

Csaba Osztrogonác
Reported 2010-11-09 12:39:52 PST
Ruby is a core part of HTML5, it should be a mandatory feature and not optional.
Attachments
proposed patch (33.07 KB, patch)
2010-11-09 13:08 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch v2 (33.67 KB, patch)
2010-11-09 14:10 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch v3 (34.07 KB, patch)
2010-11-10 00:48 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch v4 (33.61 KB, patch)
2010-11-10 07:48 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch v5 (35.97 KB, patch)
2010-11-10 09:43 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-11-09 13:08:26 PST
Created attachment 73404 [details] proposed patch
Build Bot
Comment 2 2010-11-09 13:51:29 PST
Attachment 73404 [details] did not build on win: Build output: http://queues.webkit.org/results/5470061
Csaba Osztrogonác
Comment 3 2010-11-09 14:10:40 PST
Created attachment 73412 [details] proposed patch v2 I touched WebCorePrefix.h to make Windows build happy: 3>..\html\parser\HTMLViewSourceParser.cpp : error C2220: warning treated as error - no 'object' file generated 3>..\html\parser\HTMLViewSourceParser.cpp : warning C4651: '/DENABLE_RUBY' specified for precompiled header but not for current compile
Build Bot
Comment 4 2010-11-09 16:25:30 PST
Attachment 73412 [details] did not build on win: Build output: http://queues.webkit.org/results/5531074
Csaba Osztrogonác
Comment 5 2010-11-10 00:48:06 PST
Created attachment 73468 [details] proposed patch v3 I touched config.h too to make Windows build happy. I hope it will work.
Build Bot
Comment 6 2010-11-10 02:25:47 PST
Attachment 73468 [details] did not build on win: Build output: http://queues.webkit.org/results/5552069
Csaba Osztrogonác
Comment 7 2010-11-10 02:39:30 PST
I have no idea how can I make MSVC to update all precompiled header. :( Could you give me a hint what should I do?
Adam Roben (:aroben)
Comment 8 2010-11-10 04:53:15 PST
(In reply to comment #7) > I have no idea how can I make MSVC to update all precompiled header. :( > Could you give me a hint what should I do? Touching wtf/Platform.h should do it, though unfortunately that will make all ports do a clean build instead of just Windows. We really need to fix bug 48755!
Csaba Osztrogonác
Comment 9 2010-11-10 07:48:28 PST
Created attachment 73499 [details] proposed patch v4 Touch Platform.h.
Build Bot
Comment 10 2010-11-10 09:07:29 PST
Attachment 73499 [details] did not build on win: Build output: http://queues.webkit.org/results/5466084
Csaba Osztrogonác
Comment 11 2010-11-10 09:43:48 PST
Created attachment 73502 [details] proposed patch v5 Touch the following headers: - JavaScriptCore/JavaScriptCorePrefix.h - WebCore/WebCorePrefix.h - WebKit/win/WebKitPrefix.h - WebKit2/WebKit2Prefix.h
Dave Hyatt
Comment 12 2010-11-10 10:34:54 PST
Comment on attachment 73502 [details] proposed patch v5 r=me. Yay! Thanks for doing this.
Csaba Osztrogonác
Comment 13 2010-11-10 10:44:08 PST
Comment on attachment 73502 [details] proposed patch v5 Clearing flags on attachment: 73502 Committed r71754: <http://trac.webkit.org/changeset/71754>
Csaba Osztrogonác
Comment 14 2010-11-10 10:44:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.