Bug 49259 – Rename GeolocationControllerClient to GeolocationClient

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[John Knottenbelt]

Rename WebCore::GeolocationControllerClient to WebCore::GeolocationClient to be more consistent with other Controller / Client pairs:
 - ContextMenuController / ContextMenuClient
 - DragController / DragClient
 - DeviceOrientationController / DeviceOrientationClient
 - DeviceMotionController / DeviceMotionClient

[John Knottenbelt]

Created attachment 73474 [details]
Patch

[Steve Block]

Let's get this resolved before we add the client mock in Bug 49258.

[Steve Block]

Comment on attachment 73474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73474&action=review

Sounds good to me. InspectorController/InspectorClient also follows this pattern. The only other example I can see of the other style is BackForwardController/BackForwardControllerClient.

This patch appears to be missing the change to GeolocationClient.h/cpp?

Also, it looks like you might need to rebase for win before landing.

> WebKit/mac/WebView/WebView.mm:710
> +    pageClients.geolocationControllerClient = new WebGeolocationClient(self);

Can you fix up PageClients to reflect the new name?

[John Knottenbelt]

Created attachment 73609 [details]
Rename GeolocationControllerClient -> GeolocationClient

Rename page clients as well.

[Steve Block]

Comment on attachment 73609 [details]
Rename GeolocationControllerClient -> GeolocationClient

Looks good but git has lost the SVN renaming history. I'll take the patch and fix it up with my SVN checkout.

[Steve Block]

Created attachment 73616 [details]
Patch

[John Knottenbelt]

LGTM. Patch is the same as mine, but with proper svn rename tracking.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73616 [details]:

http/tests/appcache/top-frame-3.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73616 [details]
Patch

Rejecting patch 73616 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 73616]" exit_code: 2
Last 500 characters of output:
Kit/mac/WebView/WebView.mm
	M	WebKit/win/ChangeLog
	M	WebKit/win/WebKit.vcproj/WebKit.vcproj
	M	WebKit/win/WebView.cpp
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/5698002

[Steve Block]

Created attachment 73726 [details]
Patch

[Steve Block]

Comment on attachment 73726 [details]
Patch

Fixed 'OOPS'

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 73726 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 73726 [details]
Patch

Clearing flags on attachment: 73726

Committed r71903: <http://trac.webkit.org/changeset/71903>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/71903 might have broken GTK Linux 32-bit Release
The following tests are not passing:
http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html