Bug 49249 – Output of old-run-webkit-tests is buggy in verbose mode

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

output without verbose option:
-------------------------------
svg/custom .......................................................
svg/custom/mask-colorspace.svg -> new
...............

buggy output with verbose option:
----------------------------------
...
running svg/custom/marker-referencePoint.svg -> succeeded
running svg/custom/marker-strokeWidth-changes.svg -> succeeded
running svg/custom/mask-colorspace.svg -> new test
new
running svg/custom/mask-invalidation.svg -> succeeded
running svg/custom/mask-on-multiple-objects.svg -> succeeded
...


expected output with verbose option:
-------------------------------------
...
running svg/custom/marker-referencePoint.svg -> succeeded
running svg/custom/marker-strokeWidth-changes.svg -> succeeded
running svg/custom/mask-colorspace.svg -> new test
running svg/custom/mask-invalidation.svg -> succeeded
running svg/custom/mask-on-multiple-objects.svg -> succeeded
...

[Csaba Osztrogonác]

Created attachment 73364 [details]
proposed fix

[Tor Arne Vestbø]

Comment on attachment 73364 [details]
proposed fix

LGTM, this has been annoying me as well

[WebKit Commit Bot]

Comment on attachment 73364 [details]
proposed fix

Rejecting patch 73364 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
......................
java/lc3/JSObject .............
java/lc3/JSObject/ToObject-001.html -> failed

Exiting early after 1 failures. 17829 tests run.
304.70s total testing time

17828 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd']" exit_code: 1
 layout
6 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/5539057

[Csaba Osztrogonác]

Comment on attachment 73364 [details]
proposed fix

Andreas told me, that --new-test-results --verbose mode is still buggy:
...
running svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg -> new test
new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)
...

I propose the following output for this case:
...
running svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)
...

New patch is coming soon.

[Csaba Osztrogonác]

Created attachment 73371 [details]
proposed fix v2

With this new, sophisticated patch we will get the following outputs:

without option:
----------------
svg/text .
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new
.
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new


with --verbose option:
-----------------------
running svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new test
running svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new test


with --new-test-results option:
--------------------------------
svg/text .
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)
.
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)


with --verbose --new-test-results options:
-------------------------------------------
running svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)
running svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg -> new test (results generated in /home/oszi/WebKit/LayoutTests/platform/qt/svg/text)

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/71627