Bug 4923

Summary:

stop using <ostream> in WebCore, eliminating the <cmath> troubles it causes

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch to remove the use of <ostream> and take out <math.h> workarounds	eric: review-
new patch; needs testing on gcc 4, but otherwise ready for review	mjs: review-
another pass -- this patch tested on both gcc 3 and gcc 4	ggaren: review+

Darin Adler

Reported 2005-09-10 14:47:23 PDT

For historical reasons, various WebCore classes have debug-only code that outputs them to a std::ostream. This requires include the header <ostream>, which in turn includes <cmath>, which causes us to run afoul of some troubles because <cmath> undefines the macros from <math.h>.

Attachments
patch to remove the use of <ostream> and take out <math.h> workarounds (23.98 KB, patch) 2005-09-10 14:48 PDT, Darin Adler	eric: review-	Details Formatted Diff Diff
new patch; needs testing on gcc 4, but otherwise ready for review (27.23 KB, patch) 2005-10-11 09:37 PDT, Darin Adler	mjs: review-	Details Formatted Diff Diff
another pass -- this patch tested on both gcc 3 and gcc 4 (61.27 KB, patch) 2005-12-19 10:54 PST, Darin Adler	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2005-09-10 14:48:03 PDT

Created attachment 3850 [details] patch to remove the use of <ostream> and take out <math.h> workarounds

Eric Seidel (no email)

Comment 2 2005-09-10 20:06:50 PDT

Comment on attachment 3850 [details] patch to remove the use of <ostream> and take out <math.h> workarounds The changes for everything but KWQDef.h look fine. Removing qRound and the 64 bit types will break KDOM's build.

Darin Adler

Comment 3 2005-09-10 20:25:49 PDT

OK. Eric, here's something to bring up with the KSVG folks: Going forward, is there a reason that KSVG needs to use Q types for 64-bit rather than standard C types? And is there a reason it can't just call the C standard lround instead of qRound? I think a good rule is to use Qt stuff if there isn't a standard C alternative, but not if there is.

Eric Seidel (no email)

Comment 4 2005-09-10 21:16:53 PDT

Comment on attachment 3850 [details] patch to remove the use of <ostream> and take out <math.h> workarounds This breaks building under 4.0 (thus will break the opensource folks). Also please add back the 16 and 64 bit types, and qRound as otherwise WebCore+SVG build will break when landing. Otherwise the patch looks fine.

Darin Adler

Comment 5 2005-10-11 09:37:37 PDT

Created attachment 4312 [details] new patch; needs testing on gcc 4, but otherwise ready for review

Maciej Stachowiak

Comment 6 2005-10-13 23:15:24 PDT

In general, r=me, but please test on gcc4. I am going to r- this until it works with gcc4, so it does not get accidentally committed; but please consider it an r+ and feel free to make it so once fixed on gcc4.

Darin Adler

Comment 7 2005-12-19 10:54:54 PST

Created attachment 5154 [details] another pass -- this patch tested on both gcc 3 and gcc 4

Darin Adler

Comment 8 2005-12-19 10:55:18 PST

Comment on attachment 5154 [details] another pass -- this patch tested on both gcc 3 and gcc 4 Last time the concerns were SVG and gcc 4. This patch compiles with SVG and works with both gcc 3 and gcc 4.

Geoffrey Garen

Comment 9 2005-12-19 11:06:35 PST

Comment on attachment 5154 [details] another pass -- this patch tested on both gcc 3 and gcc 4 r=me

Eric Seidel (no email)

Comment 10 2005-12-19 11:15:41 PST

Comment on attachment 5154 [details] another pass -- this patch tested on both gcc 3 and gcc 4 Looks good. r=me.

Note You need to log in before you can comment on or make changes to this bug.