Bug 49202

Summary: Make lists work with vertical text.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-11-08 13:17:04 PST 
List items need to work with vertical text.
Comment 1 Dave Hyatt 2010-11-09 14:00:49 PST 
Created attachment 73411 [details]
Patch
Comment 2 mitz 2010-11-09 14:22:24 PST 
Comment on attachment 73411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73411&action=review

> WebCore/rendering/RenderListMarker.cpp:1496
> -                        marginLeft = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2;
> +                        marginStart = m_text.isEmpty() ? 0 : -minPreferredLogicalWidth() - offset / 2;

I’d expect this to cause some right-to-left markers to shift by 1 pixel since the remainder goes to the other side now. Maybe we don’t have any tests covering this.
Comment 3 Dave Hyatt 2010-11-09 17:46:22 PST 
Fixed in r71700.