Bug 49195 – webkit-patch failure-reason explodes if a build is missing

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

webkit-patch failure-reason explodes if a build is missing

[Eric Seidel (no email)]

Created attachment 73257 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 73257 [details]
Patch

Looks fine to me but I don't feel qualified to r+ it.

[Eric Seidel (no email)]

This is what the explosion looks like:


Traceback (most recent call last):
 File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 70, in <module>
   main()
 File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 65, in main
   WebKitPatch(__file__).main()
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py",
line 308, in main
   result = command.check_arguments_and_execute(options, args, self)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py",
line 117, in check_arguments_and_execute
   return self.execute(options, args, tool) or 0
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queries.py",
line 287, in execute
   return self._explain_failures_for_builder(builder,
start_revision=int(start_revision))
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/queries.py",
line 244, in _explain_failures_for_builder
   latest_results = build.layout_test_results()
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/buildbot.py",
line 232, in layout_test_results
   self._layout_test_results =
LayoutTestResults.results_from_string(self._fetch_results_html())
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/layouttestresults.py",
line 75, in results_from_string
   parsed_results = cls._parse_results_html(string)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/layouttestresults.py",
line 62, in _parse_results_html
   tables = BeautifulSoup(page).findAll("table")
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py",
line 1499, in __init__
   BeautifulStoneSoup.__init__(self, *args, **kwargs)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py",
line 1230, in __init__
   self._feed(isHTML=isHTML)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py",
line 1245, in _feed
   smartQuotesTo=self.smartQuotesTo, isHTML=isHTML)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py",
line 1751, in __init__
   self._detectEncoding(markup, isHTML)
 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/thirdparty/BeautifulSoup.py",
line 1899, in _detectEncoding
   xml_encoding_match = re.compile(xml_encoding_re).match(xml_data)
TypeError: expected string or buffer

[Eric Seidel (no email)]

Created attachment 73276 [details]
Add a comment explaining why it might return None

[Adam Barth]

Comment on attachment 73276 [details]
Add a comment explaining why it might return None

View in context: https://bugs.webkit.org/attachment.cgi?id=73276&action=review

> WebKitTools/Scripts/webkitpy/common/net/buildbot.py:223
> +            # It seems this can return None if the url redirects and then returns 404.

Do other clients of this method need to understand that case?

[Eric Seidel (no email)]

(In reply to comment #5)
> (From update of attachment 73276 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73276&action=review
> 
> > WebKitTools/Scripts/webkitpy/common/net/buildbot.py:223
> > +            # It seems this can return None if the url redirects and then returns 404.
> 
> Do other clients of this method need to understand that case?

They all do already.  This was the one outlier.

[Eric Seidel (no email)]

Committed r71571: <http://trac.webkit.org/changeset/71571>