Summary: | Windows build fails mysteriously when .vsprops files are updated | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||
Component: | New Bugs | Assignee: | Adam Roben (:aroben) <aroben> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dbates, eric, sfalken, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-11-08 08:46:30 PST
Created attachment 73243 [details]
Patch
Comment on attachment 73243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73243&action=review > JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd:11 > +set Message= I've deleted this line locally. It wasn't meant to be left in. Committed r71532: <http://trac.webkit.org/changeset/71532> I rolled out this change in r71545 because it broke the build for people using Cygwin 1.7. http://trac.webkit.org/changeset/71532 might have broken GTK Linux 64-bit Debug I think we could fix this by modifying the react-to-vsprops-changes.py script that JavaScriptCoreGenerated runs to touch wtf/Platform.h whenever it is older than any .vsprops file. I'm working on this. I'm going to make it so we don't have to copy vsprops files at all. Created attachment 74566 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Created attachment 74569 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Comment on attachment 74569 [details]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
r=me
Committed r72555: <http://trac.webkit.org/changeset/72555> |