Bug 49181

Summary: Windows build fails mysteriously when .vsprops files are updated
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, sfalken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
none
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files hyatt: review+

Adam Roben (:aroben)
Reported 2010-11-08 08:46:30 PST
Windows build fail mysteriously when .vsprops files are updated
Attachments
Patch (6.88 KB, patch)
2010-11-08 08:49 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files (134.56 KB, patch)
2010-11-22 09:51 PST, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files (139.87 KB, patch)
2010-11-22 10:01 PST, Adam Roben (:aroben) 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-11-08 08:49:07 PST
Created attachment 73243 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-08 08:52:49 PST
Comment on attachment 73243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73243&action=review > JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd:11 > +set Message= I've deleted this line locally. It wasn't meant to be left in.
Adam Roben (:aroben)
Comment 3 2010-11-08 09:19:04 PST
Committed r71532: <http://trac.webkit.org/changeset/71532>
Adam Roben (:aroben)
Comment 4 2010-11-08 11:06:13 PST
I rolled out this change in r71545 because it broke the build for people using Cygwin 1.7.
WebKit Review Bot
Comment 5 2010-11-08 11:41:43 PST
http://trac.webkit.org/changeset/71532 might have broken GTK Linux 64-bit Debug
Adam Roben (:aroben)
Comment 6 2010-11-19 17:28:17 PST
I think we could fix this by modifying the react-to-vsprops-changes.py script that JavaScriptCoreGenerated runs to touch wtf/Platform.h whenever it is older than any .vsprops file.
Adam Roben (:aroben)
Comment 7 2010-11-22 08:46:45 PST
I'm working on this. I'm going to make it so we don't have to copy vsprops files at all.
Adam Roben (:aroben)
Comment 8 2010-11-22 09:51:25 PST
Created attachment 74566 [details] Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Adam Roben (:aroben)
Comment 9 2010-11-22 10:01:14 PST
Created attachment 74569 [details] Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Dave Hyatt
Comment 10 2010-11-22 13:12:47 PST
Comment on attachment 74569 [details] Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files r=me
Adam Roben (:aroben)
Comment 11 2010-11-22 13:51:15 PST
Committed r72555: <http://trac.webkit.org/changeset/72555>
Note You need to log in before you can comment on or make changes to this bug.